Date: Tue, 12 Aug 2008 18:06:10 +0200 From: Michael <freebsdports@bindone.de> To: "freebsd-ports-bugs@freebsd.org >> \"freebsd-ports-bugs@freebsd.org\"" <freebsd-ports-bugs@freebsd.org> Subject: Re: ports/124841: [PATCH] devel/zthread: Fix signature in BlockingQueue.h Message-ID: <48A1B4F2.6010806@bindone.de> In-Reply-To: <20080621174448.78623.qmail@mail.bindone.de> References: <20080621174448.78623.qmail@mail.bindone.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello,
I sent this in about 7 weeks ago, still no feedback. Doesn anyone know
if shaun is still alive? Any chance to get this commited?
/michael
Michael wrote:
>> Number: 124841
>> Category: ports
>> Synopsis: [PATCH] devel/zthread: Fix signature in BlockingQueue.h
>> Confidential: no
>> Severity: non-critical
>> Priority: low
>> Responsible: freebsd-ports-bugs
>> State: open
>> Quarter:
>> Keywords:
>> Date-Required:
>> Class: change-request
>> Submitter-Id: current-users
>> Arrival-Date: Sat Jun 21 17:50:00 UTC 2008
>> Closed-Date:
>> Last-Modified:
>> Originator: Michael Gmelin
>> Release: FreeBSD 6.2-RELEASE-p3 i386
>> Organization:
> /bin/done digital solutions GmbH
>> Environment:
> System: FreeBSD bombat.bindone.de 6.2-RELEASE-p3 FreeBSD 6.2-RELEASE-p3 #24: Wed May 16 20:01:05 CEST 2007
>> Description:
> Two patches, one to fix a signed to unsigned comparison in Barrier.h and
> more importantly a fix of the signature of the overloaded
> bool BlockingQueue::add(item, timeout) member function in BlockingQueue.h,
> which rendered using the feature impossible.
>
> Since my previous attempts to contact Eric about other patches were not
> successful and therefore I do not expect new releases of ZThread anytime in
> the near future, I suggest fixing this in the port skeleton.
>
> Portlint complained about an old README.html in the port as well, you might
> consider removing this when applying these patches.
>
> Added file(s):
> - files/patch-include_zthread_Barrier.h
> - files/patch-include_zthread_BlockingQueue.h
>
> Port maintainer (shaun@FreeBSD.org) is cc'd.
>
> Generated with FreeBSD Port Tools 0.77
>> How-To-Repeat:
>> Fix:
>
> --- zthread-2.3.2_1.patch begins here ---
> diff -ruN --exclude=CVS /usr/ports/devel/zthread.orig/Makefile /usr/ports/devel/zthread/Makefile
> --- /usr/ports/devel/zthread.orig/Makefile Sat Apr 21 17:17:27 2007
> +++ /usr/ports/devel/zthread/Makefile Sat Jun 21 19:21:00 2008
> @@ -7,6 +7,7 @@
>
> PORTNAME= zthread
> PORTVERSION= 2.3.2
> +PORTREVISION= 1
> CATEGORIES= devel
> MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
> MASTER_SITE_SUBDIR= ${PORTNAME}
> diff -ruN --exclude=CVS /usr/ports/devel/zthread.orig/files/patch-include_zthread_Barrier.h /usr/ports/devel/zthread/files/patch-include_zthread_Barrier.h
> --- /usr/ports/devel/zthread.orig/files/patch-include_zthread_Barrier.h Thu Jan 1 01:00:00 1970
> +++ /usr/ports/devel/zthread/files/patch-include_zthread_Barrier.h Sat Jun 21 19:24:26 2008
> @@ -0,0 +1,20 @@
> +--- include/zthread/Barrier.h.orig Sun Mar 13 06:23:00 2005
> ++++ include/zthread/Barrier.h Sat Jun 21 17:31:14 2008
> +@@ -150,7 +150,7 @@
> +
> + } else {
> +
> +- int myGeneration = _generation;
> ++ unsigned int myGeneration = _generation;
> +
> + try {
> +
> +@@ -251,7 +251,7 @@
> +
> + } else {
> +
> +- int myGeneration = _generation;
> ++ unsigned int myGeneration = _generation;
> +
> + try {
> +
> diff -ruN --exclude=CVS /usr/ports/devel/zthread.orig/files/patch-include_zthread_BlockingQueue.h /usr/ports/devel/zthread/files/patch-include_zthread_BlockingQueue.h
> --- /usr/ports/devel/zthread.orig/files/patch-include_zthread_BlockingQueue.h Thu Jan 1 01:00:00 1970
> +++ /usr/ports/devel/zthread/files/patch-include_zthread_BlockingQueue.h Sat Jun 21 19:19:17 2008
> @@ -0,0 +1,11 @@
> +--- include/zthread/BlockingQueue.h.orig Sun Mar 13 03:04:18 2005
> ++++ include/zthread/BlockingQueue.h Sat Jun 21 17:31:14 2008
> +@@ -83,7 +83,7 @@
> + /**
> + * @see Queue::add(const T& item, unsigned long timeout)
> + */
> +- virtual bool add(T item, unsigned long timeout) {
> ++ virtual bool add(const T& item, unsigned long timeout) {
> +
> + try {
> +
> --- zthread-2.3.2_1.patch ends here ---
>
>> Release-Note:
>> Audit-Trail:
>> Unformatted:
> _______________________________________________
> freebsd-ports-bugs@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
> To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48A1B4F2.6010806>