From owner-svn-src-all@freebsd.org Wed Jan 16 15:49:35 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 147AE148CAD0 for ; Wed, 16 Jan 2019 15:49:35 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 82EDE7314C for ; Wed, 16 Jan 2019 15:49:34 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1547652751; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=QI+1ra049tWPKVNACCg26DLSBJKQ/rigc2eHhIelXfDxnR13I+VL2j1MDw+vLn099E0OL8DRdlxMD l/fJXn+dOi/rKaQlbbDi4SGqnmmRcHiuM1y1L+EdMNlF2B17FhR87kOFdW8b5qZfzb0pw/6knxI4UP kpTElvtRXWTG+P0mSZOlkl0i2JnC0/5VpyM5N5jA4Ayjen2O7e0hRID9dQ2H59DxtPBkc6TbsvBttr hLhko2SNUmNIjNZY8sZNLH1QsFcnXMuSKrEpu61fOalwrHJ+QdhChdvtW5JxLizkmGXPMrp9nxSAdV 3XbkePeUvSjZxqAqfpKlgGvJlDn0BkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=yAC8gX5qGWhxdWU0hKZhTTczYvKmL+gAY2fQsFsM/is=; b=qAGLqaZ4yt60wYqO5WBGFUBqLIi/yB4MLgO0KUk3D6QKyPWhLjlayE3RUlddGko/N3+5L0JtsQ0O2 QVCDi6pkn06pnxszlGtK911jyY762/NgA1IMG/z+O/rPe0vYJB+Z0BSFTMyzih76IW1Yu3yyCzVBD6 sTKKbBqnS3MSw4N2TJj6I4KDsoQgRLOC37otC9KIgsRcXXTEAoKPMIHv+onzoZ3U5hp+3OYljTQHi/ CqqK8+gjcUC6CMDgw+hJ6rWu7Z8lGBqPPOf+0TA6R556GXvqSOJIMKoXHrmzTl6Z9pc9PWu+m1yOu/ GgwvHSYLZs9PZsOUca/S05bzIUHVb1g== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=yAC8gX5qGWhxdWU0hKZhTTczYvKmL+gAY2fQsFsM/is=; b=Ucts5aWcpB3WKJtLTVJyTsR39vbkbszqqaso71VKvDrgaYHVRJc8qV6IsiXGVO54UyTKGySUMM59E pwmwt98suz/8L0qQ8LfwmVN7FxwEJTTZJ3vRVEc0rvTfQeqHF6L6J5HEL18Jv6AW2itR6n901THCrp XGXiQrRG0qa65X28MJWGSxwm2u3gs1To9xOBnmQ7cn38lRrW9jM/tdBMAwH2S/ad8FPnCJLHy2htr8 d0J9R1JnlqCxvnNGIPjP6TMKf8a/WuV0zapr2P+NyYCeyOd1MJu3ephKLylxJGNm8hFrnnJRNumRDP H8TGBfA8OzpbMBlSklBPV4jiKgzuPrQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: ef4683c3-19a3-11e9-a59a-7b143e15dabc X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id ef4683c3-19a3-11e9-a59a-7b143e15dabc; Wed, 16 Jan 2019 15:32:30 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x0GFXMKI074617; Wed, 16 Jan 2019 08:33:22 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <604708565c923c1fdba0924ccc497ee5cb6595d8.camel@freebsd.org> Subject: Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm From: Ian Lepore To: Gleb Smirnoff Cc: Justin Hibbits , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 16 Jan 2019 08:33:22 -0700 In-Reply-To: <20190115203316.GA18452@FreeBSD.org> References: <201901151933.x0FJXl8a069317@repo.freebsd.org> <20190115134623.139064b2@titan.knownspace> <20190115200617.GZ18452@FreeBSD.org> <79ee763bb72a47f3e7888caf266174a62c23e532.camel@freebsd.org> <20190115203316.GA18452@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 82EDE7314C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.989,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 15:49:35 -0000 On Tue, 2019-01-15 at 12:33 -0800, Gleb Smirnoff wrote: > On Tue, Jan 15, 2019 at 01:20:14PM -0700, Ian Lepore wrote: > I> On Tue, 2019-01-15 at 12:06 -0800, Gleb Smirnoff wrote: > I> > On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote: > I> > J> Why not #include counter.h in the relevant vm_machdep.c files > I> > instead? > I> > > I> > This also is ugly :( Not sure more or less. Probably less, but I > I> > urged to plug all possible compilation failures at a time. > I> > > I> > What is ugly is that most files just need counter_u64_t size, > I> > and they don't use counter(9) KPI. > I> > > I> > The fact that vm_machdep or Linux KPI want to look into internal > I> > type uma_zone_t is also ugly. > I> > > I> > I> Isn't the usual fix for this problem to create a __counter_u64_t > in > I> sys/types.h and use it in places where including the full header > file > I> is undesirable for some reason? > > I'm inclined to this solution. Do you want to sign up as reviewer? :) > I can barely keep up with reading all my freebsd-related email these days, I'd better not commit to a review that I may not actually get around to. :/ -- Ian