Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Jun 2004 04:30:46 GMT
From:      Marcel Moolenaar <marcel@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 54687 for review
Message-ID:  <200406120430.i5C4UkNS051910@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=54687

Change 54687 by marcel@marcel_nfs on 2004/06/12 04:30:17

	The very first kernel dump will be saved as dump 0, not 1.

Affected files ...

.. //depot/projects/gdb/usr.bin/kgdb/main.c#9 edit

Differences ...

==== //depot/projects/gdb/usr.bin/kgdb/main.c#9 (text+ko) ====

@@ -194,6 +194,8 @@
 	int f, nfds, status;
 	int ch;
 
+	dumpnr = -1;
+
 	strlcpy(crashdir, "/var/crash", sizeof(crashdir));
 	s = getenv("KGDB_CRASH_DIR");
 	if (s != NULL)
@@ -206,7 +208,7 @@
 			break;
 		case 'n':
 			dumpnr = strtol(optarg, &s, 0);
-			if (dumpnr == 0 || *s != '\0') {
+			if (dumpnr < 0 || *s != '\0') {
 				warnx("option %c: invalid kernel dump number",
 				    optopt);
 				usage();
@@ -227,7 +229,7 @@
 	if (verbose > 1)
 		warnx("using %s as the crash directory", crashdir);
 
-	if (dumpnr)
+	if (dumpnr >= 0)
 		use_dump(dumpnr);
 
 	if (argc > 0) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406120430.i5C4UkNS051910>