From owner-freebsd-bugs@FreeBSD.ORG  Thu Apr 27 15:10:19 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D133116A402
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 27 Apr 2006 15:10:19 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6413F43D45
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 27 Apr 2006 15:10:19 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3RFAJtp057367
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 27 Apr 2006 15:10:19 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3RFAJ9n057366;
	Thu, 27 Apr 2006 15:10:19 GMT (envelope-from gnats)
Date: Thu, 27 Apr 2006 15:10:19 GMT
Message-Id: <200604271510.k3RFAJ9n057366@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Yuri Pankov <yuri.pankov@gmail.com>
Cc: 
Subject: Re: kern/96391: [nve] [patch] Device timeouts on nve(4)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Yuri Pankov <yuri.pankov@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Apr 2006 15:10:19 -0000

The following reply was made to PR kern/96391; it has been noted by GNATS.

From: Yuri Pankov <yuri.pankov@gmail.com>
To: bug-followup@FreeBSD.org,  nathanw@uchicago.edu
Cc:  
Subject: Re: kern/96391: [nve] [patch] Device timeouts on nve(4)
Date: Thu, 27 Apr 2006 19:02:24 +0400

 Indeed, patch seems to get rid of timeout(N) messages. Though it doesn't 
 apply cleanly to -CURRENT source. Here's patch against rev 1.20 of if_nve.c:
 
 --- if_nve.c.orig       Mon Dec 12 09:23:43 2005
 +++ if_nve.c    Thu Apr 27 18:23:48 2006
 @@ -1277,6 +1277,18 @@
   {
          struct nve_softc *sc = ifp->if_softc;
 
 +       NVE_LOCK(sc);
 +       /* Check for lost interrupts -- happens on nForce4 */
 +       sc->hwapi->pfnDisableInterrupts(sc->hwapi->pADCX);
 +       sc->hwapi->pfnHandleInterrupt(sc->hwapi->pADCX);
 +       sc->hwapi->pfnEnableInterrupts(sc->hwapi->pADCX);
 +
 +       if (sc->pending_txs == 0) {
 +               NVE_UNLOCK(sc);
 +               return; /* Problem went away */
 +       }
 +       NVE_UNLOCK(sc);
 +
          device_printf(sc->dev, "device timeout (%d)\n", c->pending_txs);
 
          NVE_LOCK(sc);