From owner-svn-src-head@freebsd.org Sun Oct 25 15:04:07 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1FFAE451221; Sun, 25 Oct 2020 15:04:07 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CK1T307Tcz48vX; Sun, 25 Oct 2020 15:04:07 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id D73EE195EA; Sun, 25 Oct 2020 15:04:06 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f180.google.com with SMTP id z6so6101505qkz.4; Sun, 25 Oct 2020 08:04:06 -0700 (PDT) X-Gm-Message-State: AOAM5310XHqItSeyd8v/aID4pyhfOU+CHe6V2XW9yw99V18g6EzY4LOL C5gWLc6UYkQCm17RvHEQbclmw3u4zqohwhXZnLc= X-Google-Smtp-Source: ABdhPJxlizOhqcYl9Fc7I/uvurhmhuqaZIjcsQ0yaTQlCTeU/tB6G18x/MT7cT5gGMi13HPOegCCER79rda3AzMZ7GM= X-Received: by 2002:a05:620a:ced:: with SMTP id c13mr13057165qkj.120.1603638246470; Sun, 25 Oct 2020 08:04:06 -0700 (PDT) MIME-Version: 1.0 References: <202010250346.09P3kTVH076745@gndrsh.dnsmgr.net> In-Reply-To: From: Kyle Evans Date: Sun, 25 Oct 2020 10:03:55 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r366962 - in head: include usr.bin/calendar To: Stefan Esser Cc: "Rodney W. Grimes" , Warner Losh , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Oct 2020 15:04:07 -0000 On Sun, Oct 25, 2020 at 5:21 AM Stefan Esser wrote: > > Am 25.10.20 um 04:46 schrieb Rodney W. Grimes: > >> On Sat, Oct 24, 2020 at 8:51 PM Rodney W. Grimes > >> wrote: > >>>> +#define _PATH_LOCALBASE "/usr/local" > >>>> + > >>> > >>> Something feels very wrong about this becoming a defined path in base, > >>> it is further dependence on /usr/local which in the early days we spent > >>> a great deal of time removing. > >>> > >>> I believe the whole ports system allows this to be something other > >>> than /usr/local. Package should also allow it to be some other place. > >>> > >> > >> This removes a couple of instances of /usr/local being hardcoded and > >> replaces with a define, so net it's better. > > > > No, its net worse as it now creates a define that is highly likely > > to propogate adding additional dependencies on this value. > > > >> > >> It could be even better, but this is slightly better than it was before. > > > > I disagree, as it is now easier for additional contamination of > > the base system. > > There already are places that hard-code /usr/local, and I do agree > that this is architecturally bad, if you want to keep the base system > and ports as independent from each other as possible. > > But I do disagree that this was worse than before, and I'd even consider > replacing other verbatim occurrences of /usr/local with _PATH_LOCALBASE > in our sources (but not introduce new references to LOCALBASE in base). > > This would simplify a grep for such source files, for example, and also > to build base for systems with modified LOCALBASE. > > The following C header files in base (ignoring contrib) contain the > string /usr/local: > > ... > sys/contrib/openzfs/include/sys/lua/luaconf.h (FreeBSD specific?) > ... I see that you've excluded sys/contrib from the initial review, but I would not bother with luaconf.h in particular. These definitions just come from a stock Lua 5.2 and are not used in a ZFS context, they've ripped out loadlib and anything else that could try. Thanks, Kyle Evans