From owner-freebsd-current@FreeBSD.ORG Fri Nov 3 22:20:57 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D93E16A54F; Fri, 3 Nov 2006 22:20:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id B551D43D73; Fri, 3 Nov 2006 22:20:56 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kA3MJK0i080916; Fri, 3 Nov 2006 15:19:20 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Fri, 03 Nov 2006 15:19:48 -0700 (MST) Message-Id: <20061103.151948.1102530221.imp@bsdimp.com> To: dougb@freebsd.org From: "M. Warner Losh" In-Reply-To: <454BBF4C.3040205@FreeBSD.org> References: <454BBF4C.3040205@FreeBSD.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 03 Nov 2006 15:19:21 -0700 (MST) Cc: freebsd-current@freebsd.org Subject: Re: Panic w/latest sources X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2006 22:20:57 -0000 In message: <454BBF4C.3040205@FreeBSD.org> Doug Barton writes: : > I have up to the minute -current sources, running on an Intel core : > 2 duo in i386+SMP. Right after probing the PCI bus (pci0: : > on pcib0) I get a panic. rman_get_start+0x6: movl 0(%eax),%eax : > : > GENERIC kernel from the October snapshot works fine. : : I'm afraid Warner is on the hook for this one. Reverting this change : allows me to boot a new kernel with otherwise up to date sources. : : Warner, let me know if there is anything I can do to help, test, etc. Try the latest code. Should be fixed already. There was a use the res before checking to see if it was NULL bug that I fixed after the commit you quoted. Warner : Doug : : -------- Original Message -------- : Subject: cvs commit: src/sys/dev/pci pci.c pci_pci.c pcivar.h : Date: Mon, 30 Oct 2006 19:18:46 +0000 (UTC) : From: Warner Losh : To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org : : imp 2006-10-30 19:18:46 UTC : : FreeBSD src repository : : Modified files: : sys/dev/pci pci.c pci_pci.c pcivar.h : Log: : More fully support 64-bit bars. Prior to this commit, we supported : only those bars that had addresses assigned by the BIOS and where the : bridges were properly programmed. Now even unprogrammed ones work. : This was needed for sun4v. We still only implement up to 2GB memory : ranges, even for 64-bit bars. PCI standards at least through 2.2 say : that this is the max (or 1GB is, I only know it is < 32bits). : : o Always define pci_addr_t as uint64_t. A pci address is always : 64-bits, : but some hosts can't address all of them. : o Preserve the upper half of the 64-bit word during resource probing. : o Test to make sure that 64-bit values can fit in a u_long (true on : some : platforms, but not others). Don't use those that can't. : o minor pedantry about data sizes. : o Better bridge resource reporting in bootverbose case. : o Minor formatting changes to cope with different data types on : different : platforms. : : Submitted by: jmg, with many changes by me to fully support 64-bit : addresses. : : Revision Changes Path : 1.317 +29 -12 src/sys/dev/pci/pci.c : 1.42 +39 -33 src/sys/dev/pci/pci_pci.c : 1.72 +1 -13 src/sys/dev/pci/pcivar.h : : http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/pci/pci.c.diff?&r1=1.316&r2=1.317&f=h : http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/pci/pci_pci.c.diff?&r1=1.41&r2=1.42&f=h : http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/pci/pcivar.h.diff?&r1=1.71&r2=1.72&f=h : : : -- : : This .signature sanitized for your protection : :