From owner-freebsd-bugs@FreeBSD.ORG Tue Jul 20 20:00:03 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B29A91065677 for ; Tue, 20 Jul 2010 20:00:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7304A8FC0A for ; Tue, 20 Jul 2010 20:00:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6KK03ei074501 for ; Tue, 20 Jul 2010 20:00:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6KK03Hf074500; Tue, 20 Jul 2010 20:00:03 GMT (envelope-from gnats) Resent-Date: Tue, 20 Jul 2010 20:00:03 GMT Resent-Message-Id: <201007202000.o6KK03Hf074500@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, pluknet Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84E65106564A for ; Tue, 20 Jul 2010 19:52:17 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 73B628FC14 for ; Tue, 20 Jul 2010 19:52:17 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o6KJqHXS050225 for ; Tue, 20 Jul 2010 19:52:17 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o6KJqHCd050224; Tue, 20 Jul 2010 19:52:17 GMT (envelope-from nobody) Message-Id: <201007201952.o6KJqHCd050224@www.freebsd.org> Date: Tue, 20 Jul 2010 19:52:17 GMT From: pluknet To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/148801: [patch] obsolete CAPABILITIES comment after suser(9) -> priv(9) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2010 20:00:03 -0000 >Number: 148801 >Category: kern >Synopsis: [patch] obsolete CAPABILITIES comment after suser(9) -> priv(9) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 20 20:00:03 UTC 2010 >Closed-Date: >Last-Modified: >Originator: pluknet >Release: HEAD r209989 >Organization: >Environment: >Description: This comment was left after "Sweep kernel replacing suser(9) calls with priv(9) calls" (svn r164033 by rwatson@) in which the exp. CAPABILITIES facility was moved to current operating priv(9). After that the comment has lost its relevance. May be applied down to 7.x. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: sys/kern/vfs_subr.c =================================================================== --- sys/kern/vfs_subr.c (revision 209989) +++ sys/kern/vfs_subr.c (working copy) @@ -3515,9 +3515,6 @@ * and optional call-by-reference privused argument allowing vaccess() * to indicate to the caller whether privilege was used to satisfy the * request (obsoleted). Returns 0 on success, or an errno on failure. - * - * The ifdef'd CAPABILITIES version is here for reference, but is not - * actually used. */ int vaccess(enum vtype type, mode_t file_mode, uid_t file_uid, gid_t file_gid, >Release-Note: >Audit-Trail: >Unformatted: