From owner-freebsd-usb@FreeBSD.ORG Thu Jan 30 06:45:40 2014 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C6BA06D7; Thu, 30 Jan 2014 06:45:40 +0000 (UTC) Received: from mta05.bitpro.no (mta05.bitpro.no [92.42.64.202]) by mx1.freebsd.org (Postfix) with ESMTP id 4C9551879; Thu, 30 Jan 2014 06:45:39 +0000 (UTC) Received: from mail.lockless.no (mail.lockless.no [46.29.221.38]) by mta05.bitpro.no (Postfix) with ESMTPS id 5648717FC8B; Thu, 30 Jan 2014 07:45:32 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.lockless.no (Postfix) with ESMTP id A7F458FAE99; Thu, 30 Jan 2014 07:46:23 +0100 (CET) X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at lockless.no Received: from mail.lockless.no ([127.0.0.1]) by localhost (mail.lockless.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vbsI6oFMMohO; Thu, 30 Jan 2014 07:46:22 +0100 (CET) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) by mail.lockless.no (Postfix) with ESMTPSA id 7205C8FAE66; Thu, 30 Jan 2014 07:46:22 +0100 (CET) Message-ID: <52E9F546.9090005@bitfrost.no> Date: Thu, 30 Jan 2014 07:46:30 +0100 From: Hans Petter Selasky Organization: Bitfrost A/S User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: huanghwh@gmail.com Subject: Re: Apple Trackpad driver References: <52E8DDA3.3070301@bitfrost.no> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "kwm@freebsd.org" , freebsd-current , "freebsd-usb@freebsd.org" X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2014 06:45:41 -0000 Hi Huang, On 01/30/14 06:56, Huang Wen Hui wrote: > Hans, > > Thanks for you take care of it and commit it! I found two problems: > > 1. The selection is not expected when selection with 2 fingers sometimes. > 2. Unexpected scrolling when Click with 2 fingers. > > This patch can fix that. The var "n" modify to "ntouch" seems to be > necessary. > Right, but aren't we then accessing non-initialised sc->pos_x[] data ? Because if ntouch == 2, n can be less than or equal to 2, due to continue in for-loop above. What is the purpose of the "n" variable? Can you explain? - if (n == 2) { + if (ntouch == 2) { sc->distance = max(sc->distance, max( abs(sc->pos_x[0] - sc->pos_x[1]), abs(sc->pos_y[0] - sc->pos_y[1]))); --HPS > > Cheers, > Huang Wen Hui > > > 2014-01-29 Hans Petter Selasky > >> On 01/29/14 09:49, Lundberg, Johannes wrote: >> >>> Hi >>> >>> I tested the driver on a 2012 Macbook Air 11" and it works great! Good >>> job! >>> >>> Is there a way to disable click-by-touch? I always preferred clicking with >>> the physical button that is built in to the pad. >>> >>> >> Hi, >> >> I've added an "#if 0" around the 1 finger tap code until further. Maybe >> this feature can be tunable? >> >> I fixed the code style, added some range checks and cleared some buffer >> issues. >> >> When you assign a signed value to an unsigned variable, you should range >> check it, because the sign might cause an overflow when you use it later on. >> >> int8_t x = -1; >> >> uint32_t t = x; >> >> "t" is now "0xffffffffU" and not "255". >> >> Tested the code on my MacBookPro. Hope I didn't break anything. If so, >> send a patch to freebsd-usb. >> >> http://svnweb.freebsd.org/changeset/base/261260 >> >> To get the touchpad working with Xorg, I needed to re-compile HALD with >> the attached patch. >> >> kwm: Can you get the attached patch into ports? >> >> Auto-loading of wsp via devd will be done later. Simply need to >> re-generate usb.conf in /etc ... >> >> --HPS >> >> >> >> >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"