From owner-freebsd-current@FreeBSD.ORG  Sat Nov 22 20:17:06 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B0C99106564A
	for <freebsd-current@freebsd.org>; Sat, 22 Nov 2008 20:17:06 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 7FA558FC12
	for <freebsd-current@freebsd.org>; Sat, 22 Nov 2008 20:17:06 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from localhost (localhost [127.0.0.1])
	by pele.citylink.co.nz (Postfix) with ESMTP id BDA8B2BC4B;
	Sun, 23 Nov 2008 09:17:05 +1300 (NZDT)
X-Virus-Scanned: Debian amavisd-new at citylink.co.nz
Received: from pele.citylink.co.nz ([127.0.0.1])
	by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id pENGT5seuxmA; Sun, 23 Nov 2008 09:17:02 +1300 (NZDT)
Received: from citylink.fud.org.nz (unknown [202.8.44.45])
	by pele.citylink.co.nz (Postfix) with ESMTP;
	Sun, 23 Nov 2008 09:17:02 +1300 (NZDT)
Received: by citylink.fud.org.nz (Postfix, from userid 1001)
	id F21FC11458; Sun, 23 Nov 2008 09:17:01 +1300 (NZDT)
Date: Sat, 22 Nov 2008 12:17:01 -0800
From: Andrew Thompson <thompsa@FreeBSD.org>
To: Max Laier <max@love2party.net>
Message-ID: <20081122201701.GA62360@citylink.fud.org.nz>
References: <20081122191744.GA62217@citylink.fud.org.nz>
	<200811222108.58061.max@love2party.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200811222108.58061.max@love2party.net>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: freebsd-current@freebsd.org
Subject: Re: config(8) patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2008 20:17:06 -0000

On Sat, Nov 22, 2008 at 09:08:57PM +0100, Max Laier wrote:
> On Saturday 22 November 2008 20:17:44 Andrew Thompson wrote:
> > Hi,
> >
> >
> > I wanted to use the following in my kernel config file so wrote a patch
> > for it.
> >
> >  makeoptions MODULES_OVERRIDE=foo
> >  makeoptions MODULES_OVERRIDE+=bar
> >  makeoptions MODULES_OVERRIDE+=baz
> >
> >  http://people.freebsd.org/~thompsa/config_append.diff
> >
> > I am unsure if the config version needs to be bumped for a minor change
> > like this. Can anyone clarify?
> 
> From my reading of the comments in configvers.h you should bump the minor 
> version.  You should, however, *not* bump the %VERSREQ in any Makefiles - this 
> would allow people to use an old config as long as they don't use your new 
> addition.

I think you are right, I have bumped from 600006 to 600007.

cheers,
Andrew