Date: Wed, 31 Oct 2018 10:06:31 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Marcelo Araujo <araujo@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339936 - head/sys/amd64/vmm/amd Message-ID: <20181031140631.ipwlwh3rlm7ma4xk@mutt-hbsd> In-Reply-To: <201810310127.w9V1RiFX025463@repo.freebsd.org> References: <201810310127.w9V1RiFX025463@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--xvtltbeb4cvnrabj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 31, 2018 at 01:27:44AM +0000, Marcelo Araujo wrote: > Author: araujo > Date: Wed Oct 31 01:27:44 2018 > New Revision: 339936 > URL: https://svnweb.freebsd.org/changeset/base/339936 >=20 > Log: > Merge cases with upper block. > This is a cosmetic change only to simplify code. > =20 > Reported by: anish > Sponsored by: iXsystems Inc. >=20 > Modified: > head/sys/amd64/vmm/amd/svm_msr.c >=20 > Modified: head/sys/amd64/vmm/amd/svm_msr.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/amd64/vmm/amd/svm_msr.c Tue Oct 30 23:09:04 2018 (r339935) > +++ head/sys/amd64/vmm/amd/svm_msr.c Wed Oct 31 01:27:44 2018 (r339936) > @@ -122,11 +122,7 @@ svm_rdmsr(struct svm_softc *sc, int vcpu, u_int num,= u > case MSR_MTRR16kBase ... MSR_MTRR16kBase + 1: > case MSR_MTRR64kBase: > case MSR_SYSCFG: > - *result =3D 0; > - break; > case MSR_AMDK8_IPM: > - *result =3D 0; > - break; > case MSR_EXTFEATURES: > *result =3D 0; > break; Does this need a /* FALLTHROUGH */ comment to appease the Coverity Gods? Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --xvtltbeb4cvnrabj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlvZtuIACgkQaoRlj1JF bu7YFxAAotLfwS4nmHkls1xlMbHO3p+lP7fFfthSLhnsEFSHLNCxtNRcLYCFyIpU TiSKpDWZ7yAJOtW5vjEjZFSRNC5CEaXBGJN0wCHdhlsbFhtdh7RvmYazNB/U6zTC hCuCdXnRThDKhfU3Rbb8Fax+Lnp/t38tm7e/w4z7h/D/6k7Fb2MjmADVAiwi5epn RLKu4KtUl3DUr2gBhsEkedJx7peWPdALiQE2MOA//A2hOTyE9SSjcL2mvOLsdC8i iVsT2bBWhVjIamxMXXjO0v+lq6eR8WGkqwDVoHHDXJcimmqtytp7rCAm+UNiI3Jg Z53edZLY1Ghj5rptb3xg/SsGUqC2GlBz+ey12YobxcX6/yPjKvJ3xO3W1FLmM+/g A8T04chtwtJG9XNe87L45TD1GvSWNR85mRHoV4TLieajUnCA8hjzovteBbcKffnt bAAwPmJ/SNVlH4+YAGN39bjfMYwqXZ/DUatbLWaUi2uG2W+i6n/Hifjr1bu3ZvOZ c/mR7IRvvQQh4QrAZXg/uR1+dPylNwwKJGt3SaauZGK1Ph5OKs1gT0JIs5eZB90e peT+KYSthlC4CVu9KKkiKzdD+vw0y9iCgb3OnbtGlp/kQfjdU0GfJlKviiucYg/T poKWItRICo32mTUmVPPKM6+4zFeEUbLgmB+02yjosN0U7/v7Z2w= =It1J -----END PGP SIGNATURE----- --xvtltbeb4cvnrabj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181031140631.ipwlwh3rlm7ma4xk>