Date: Sat, 21 Jul 2012 11:38:39 -0500 From: Scot Hetzel <swhetzel@gmail.com> To: "Jason E. Hale" <bsdkaffee@gmail.com> Cc: Doug Barton <dougb@freebsd.org>, Jeremy Messenger <mezz.freebsd@gmail.com>, ruby@freebsd.org, Edwin Groothuis <edwin@mavetju.org>, freebsd-ports@freebsd.org, gnome@freebsd.org, johans@freebsd.org Subject: Re: How to remove erroneous deps from pkgng Message-ID: <CACdU%2Bf97xFgcdAA8UqAOZDk-kHsA2Y0qLDEr38r-MsPt6a-aOw@mail.gmail.com> In-Reply-To: <15617903.FBMimp13fy@mocha.verizon.net> References: <D0056D18EAAD41119F26D0715FA52FB6@Rivendell> <CADLFttf7t8cPpXiN6b6pCv5Waxa-eVQh3Ye=i0Dydgenb7etug@mail.gmail.com> <500A4D9E.3050701@FreeBSD.org> <15617903.FBMimp13fy@mocha.verizon.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 21, 2012 at 6:59 AM, Jason E. Hale <bsdkaffee@gmail.com> wrote:
> On Friday, July 20, 2012 23:35:10 Doug Barton wrote:
>> Baptiste already volunteered to do an exp-run for this topic on Monday.
>> If you don't have time to get your changes ready before then IMO we
>> should go ahead with removing the line from bsd.gnome.mk. Making that
>> correct fix now won't negatively affect your ability to make a
>> different/better change later; but doing it now will give us more
>> opportunity to see the results and fix any regressions.
>>
> The problem with simply removing
>
> pkgconfig_RUN_DEPENDS= pkg-config:${PORTSDIR}/devel/pkg-config
>
> from bsd.gnome.mk is that there are ports that indirectly depend on pkg-config
> for their build through other ports that directly depend on it since it has
> just been a runtime dependency. I know there are quite a few KDE ports like
> that.
>
Removing this runtime dependency for pkgconfig from bsd.gnome.mk is
the correct thing to do, until we have the better frame work to
specify that pkgconfig is a build or run dependancy.
> To explain better, x11/kdelibs4 has USE_GNOME=pkgconfig, but some ports that
> depend on kdelibs4 and require pkg-config for their build are not currently
> defining USE_GNOME=pkgconfig since it is assumed that pkg-config is installed.
> A direct dependency for pkg-config would need to be added to all of those
> ports.
>
That is what the experimental run will tell us. Which ports break
when this line is removed/disabled in bsd.gnome.mk. This way we can
fix those ports by adding a BUILD_DEPENDS to them.
> I think there would be a lot less breakage if the line in bsd.gnome.mk were
> left in for now and we migrated over to the pkgconfig:build/run scheme.
>
We would still have the same amount of breakage. In your example
x11/kdelibs4 would be changed to USE_GNOME=pkgconfig:build. The ports
that still have an indirect build dependancy on pkgconfig would still
fail to build.
Scot
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACdU%2Bf97xFgcdAA8UqAOZDk-kHsA2Y0qLDEr38r-MsPt6a-aOw>