From owner-freebsd-net@FreeBSD.ORG  Tue Aug 21 16:34:43 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AF9B91065672;
	Tue, 21 Aug 2012 16:34:43 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 770548FC0A;
	Tue, 21 Aug 2012 16:34:43 +0000 (UTC)
Received: by pbbrp2 with SMTP id rp2so189613pbb.13
	for <multiple recipients>; Tue, 21 Aug 2012 09:34:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=8b6dj4QLnpKsuRXtWfPCdrNkT7HS90hq7Qkk5biz7bM=;
	b=QQSjN2u6i4xaoqlTwxOgJzEoxbmg/99TIBP5YwYbrfilkLB/j0Xtb6mmk85NGieBLt
	mvQZ7brxZiA0LHlVBYj9fjt7ZR74BNrBMxBGC8chm3LTLK3eB0DVVMA28gA9Ex8sfcv2
	A2yrsaYkUS+AUi7G0z4MVbNsl46GDF6WZ0hwkbMVfgAD/kzItKM1PIwYdDePDlY/zuUS
	dryejfQ+QbdzTx/Vr8067su3W0CbmbZrjsYdZCNLVjShyfbBh5Eh9sRDHyXen4NEcT8t
	abNW0o+7BlG/wD7GrrXs7IRwmFVytO5ZYHtUQTQi6MGvzAkfF9+QZfkKCFQKquf0rGXN
	zP2g==
MIME-Version: 1.0
Received: by 10.68.129.131 with SMTP id nw3mr45314162pbb.43.1345566882982;
	Tue, 21 Aug 2012 09:34:42 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.68.43.169 with HTTP; Tue, 21 Aug 2012 09:34:42 -0700 (PDT)
In-Reply-To: <420BA06C-C776-47DB-B3BB-F1414C115F99@bsdimp.com>
References: <50324DB4.6080905@cabletv.dp.ua>
	<alpine.BSF.2.00.1208201844220.35173@wojtek.tensor.gdynia.pl>
	<B2BB7724-57A9-40C9-AE9F-FFEC83D9DE9A@bsdimp.com>
	<alpine.BSF.2.00.1208202117230.19372@wojtek.tensor.gdynia.pl>
	<5452BF37-3658-4C1F-B965-CE3EA28B6EA5@bsdimp.com>
	<alpine.BSF.2.00.1208210942150.33814@wojtek.tensor.gdynia.pl>
	<420BA06C-C776-47DB-B3BB-F1414C115F99@bsdimp.com>
Date: Tue, 21 Aug 2012 09:34:42 -0700
X-Google-Sender-Auth: YEx0_ajkug3Y5gCsY8HfBAF0JqU
Message-ID: <CAJ-VmokQLD6YgyrsOyez=3cLm4Q8jZOnJ9vo4Wq3sjRu+G-E7A@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Warner Losh <imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Wojciech Puchar <wojtek@wojtek.tensor.gdynia.pl>, freebsd-net@freebsd.org,
	Mitya <mitya@cabletv.dp.ua>, freebsd-hackers@freebsd.org
Subject: Re: Replace bcopy() to update ether_addr
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Aug 2012 16:34:43 -0000

Hi,

What about just creating an ETHER_ADDR_COPY(dst, src) and putting that
in a relevant include file, then hide the ugliness there?

The same benefits will likely appear when copying wifi MAC addresses
to/from headers.

Thanks, I'm glad someone noticed this.




Adrian