From owner-freebsd-virtualization@freebsd.org Wed Mar 7 19:29:03 2018 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5A10DF279AB for ; Wed, 7 Mar 2018 19:29:03 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from vito.onthenet.com.au (vito.onthenet.com.au [203.22.124.72]) by mx1.freebsd.org (Postfix) with ESMTP id 7D9AA6991F for ; Wed, 7 Mar 2018 19:29:02 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) by vito.onthenet.com.au (Postfix) with ESMTP id 0A32B209867B for ; Thu, 8 Mar 2018 05:29:00 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) by alto.onthenet.com.au (Postfix) with ESMTPS id E066B20B4A16 for ; Thu, 8 Mar 2018 05:28:59 +1000 (AEST) Received: from localhost (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id DA9EF281E00 for ; Thu, 8 Mar 2018 05:28:59 +1000 (AEST) X-Amavis-Modified: Mail body modified (using disclaimer) - iredmail.onthenet.com.au Received: from iredmail.onthenet.com.au ([127.0.0.1]) by localhost (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Y1dUgqQXUJ-O for ; Thu, 8 Mar 2018 05:28:59 +1000 (AEST) Received: from Peters-MacBook-Pro-2.local (96-82-80-65-static.hfc.comcastbusiness.net [96.82.80.65]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 8C54F2804D6; Thu, 8 Mar 2018 05:28:57 +1000 (AEST) Subject: Re: Call for testing bhyve cpu topology additions To: "Rodney W. Grimes" Cc: freebsd-virtualization@freebsd.org References: <201803071920.w27JK9JQ055368@pdx.rh.CN85.dnsmgr.net> From: Peter Grehan Message-ID: Date: Wed, 7 Mar 2018 11:28:55 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <201803071920.w27JK9JQ055368@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dNCIZtRb c=1 sm=1 tr=0 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=mwgbnDbW7alINpy3vhoKyg==:17 a=IkcTkHD0fZMA:10 a=v2DPQv5-lfwA:10 a=n5e4Vix2roilDiFsZ4gA:9 a=ylQoYIHwv3EluTzj:21 a=GssiOoEsnPXuDgD0:21 a=QEXdDO2ut3YA:10 wl=host:3 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Mvd8FVSe c=1 sm=1 tr=0 a=mJOSnoNX3k71adV6TmU0eQ==:117 a=mwgbnDbW7alINpy3vhoKyg==:17 a=IkcTkHD0fZMA:10 a=v2DPQv5-lfwA:10 a=n5e4Vix2roilDiFsZ4gA:9 a=ylQoYIHwv3EluTzj:21 a=GssiOoEsnPXuDgD0:21 a=QEXdDO2ut3YA:10 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 19:29:03 -0000 > I shall iterate again, this change makes no change to what the guests > sees if you use the old method sysctl hw.vmm.topology.cores_per_package > or hw.vmm.topology.threads_per_core to set these values, it is > purely a interface enhancement that makes these tuneables easy > to access from userland bhyve(8). Those sysctls were an undocumented workaround with no error checking. You are making this a documented part of bhyve, > A guest can not tell the diffence in what way these are set. > If hw.vmm.topology.* needs testing thats not on me, that is > an existing problem, and one that has existed for far too long. Ah, no, the testing is on you, not the user community. >> You can easily download an eval of Windows 10 to try this out with. >> You do not (and have never) required ATA support to run Windows on bhyve. > > I have made a call for testing, whats your issue? > Are you trying to force me to do that testing? At a minimum, you are expected to test changes that you expect to commit. > And I consider this change rather trivial and with near 0 risk, You've never made a commit to bhyve but somehow feel qualified to make risk assessments. >> And why the rush ? I'm yet to understand what the urgency for this >> work is ? Who is demanding it ? > > The users have been wanting this for well over a year, it was > a frequently requested item when I wrote it. It is long overdue. Right, so 3 weeks for MFC is perfectly acceptable in that case. > You seem to be raising a bar higher than any other part of > FreeBSD for this rather simple user command enhancement, > can I ask what your objection is? The fact that you seem to think testing this is someone else's problem, in a subsystem where rigorous testing is a requirement. later, Peter.