From owner-freebsd-python@freebsd.org Wed Aug 23 03:33:36 2017 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3584CDD6AD6 for ; Wed, 23 Aug 2017 03:33:36 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 0728984CCB for ; Wed, 23 Aug 2017 03:33:36 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 0369BDD6AD2; Wed, 23 Aug 2017 03:33:36 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02845DD6AD1; Wed, 23 Aug 2017 03:33:36 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CB39D84CCA; Wed, 23 Aug 2017 03:33:35 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg0-x243.google.com with SMTP id y129so517778pgy.3; Tue, 22 Aug 2017 20:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q41cbpPlDVFpS61HHuRw4BJUd5MW/q7LeTVqJlo6hwk=; b=PgMMK72WATFfSfNDwA//fyg7u7uwnThTyg1QRwa4BTf4W2ns7CgvNFrNP8mTzlUd/+ n4S5PTpm1U5k81I88L59vzYCRw+zpyWmNh3r8j3zDUmeaughB0/qtQm/zbBZ1KdCf4Ko REWCNw4EyGubgMup/MgNagHvh36SvQ1c3yzH/g+/Ie3EO9NRYCyaBu40pFS6epJ9Sl4a mM2mxfMK3haIw6oAHraYn6gKfJHJlKZpT/B1B2Whcs2pILjna972Lyb4ztzRE+Om10nv Q7SyPZ829VNdSkOSXPyiTQlfuSuXtNFdWNqUoG/IVpyzkeJQOy84NUG1TSTgpRiNXXw/ +hHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=q41cbpPlDVFpS61HHuRw4BJUd5MW/q7LeTVqJlo6hwk=; b=CjlgH5+JnzSjYU61uq6ZUP06LWivOJLFoi0PJI4lJaJirUY30fpn47HrK4R1XERlKy S1VvY31ZiDNEU7qZRr+s2BiO5gVjYcnUix5iMRJum49W3JvaVw48W0FROWiOUxx7TW2q 1/c6ntd8fFT8fVmH65eQ3ljRII/W3rrn4GKD2jmuVZacUddOmlReyYQ7I/P8MpWHqWZE 6JCFyoCxli42d6XQpBGfye043FEY8YVFNAHPZLsVlMCS+4DYNARbCnkRh2yOm4N5JZxi 0LFR05tdDl5K30FO5qExGzlExpSBlfemFxVBNI810XLHzwxFCkPuXQ/WrnZ+SMeyDU3b hZzQ== X-Gm-Message-State: AHYfb5ieL18h1vaxLG1k94akC044WEhGA7U1PjJ9rhoUYUp/dVUveeef crxNZwTrroJZ8ui4jJY= X-Received: by 10.84.230.137 with SMTP id e9mr1400220plk.71.1503459214801; Tue, 22 Aug 2017 20:33:34 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:584:283a:c57e:de2a? (2001-44b8-31ae-7b01-0584-283a-c57e-de2a.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:584:283a:c57e:de2a]) by smtp.gmail.com with ESMTPSA id a4sm570746pfl.147.2017.08.22.20.33.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Aug 2017 20:33:34 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r448586 - in head/sysutils/py-salt: . files To: Ben Woods , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, "python@freebsd.org" References: <201708222302.v7MN2Llj052610@repo.freebsd.org> From: Kubilay Kocak Message-ID: <03f0b3f7-702a-2f66-a761-23585a193d86@FreeBSD.org> Date: Wed, 23 Aug 2017 13:27:49 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0a2 MIME-Version: 1.0 In-Reply-To: <201708222302.v7MN2Llj052610@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 03:33:36 -0000 On 8/23/17 9:02 AM, Ben Woods wrote: > +# Python 2.7-3.3 require enum34, unnecessary for Python 3.4+ > +.if ${PYTHON_REL} < 3400 > +RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py-enum34 > +.endif A heads-up just in case, as it has occurred numerous times in the past and is not immediately obvious ... When matching or modifying package dependencies in Python ports (conditional dependencies, updating version numbers), especially when making changes that are not reflected in the upstream sources, make sure to check and patch setup.py to make sure *everything* matches or is conditional there also. This includes when changing == to >= dependencies and similar. If they're not the same, setuptools will spit out a unsatisfied dependency errors at runtime. For conditional dependencies where some Python versions contain the module, the error will still be produced, as dependencies are checked only against third-party packages, not the standard library. In these cases it is still very much OK to depend on the PyPI (third-party) version (like enum and argparse), if one can't be bothered or does not want to patch the sources to compensate. ./koobs