From owner-freebsd-current@FreeBSD.ORG  Mon Oct 21 06:46:14 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 482D6D6;
 Mon, 21 Oct 2013 06:46:14 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com
 [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0B20D2E6B;
 Mon, 21 Oct 2013 06:46:14 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7::d87c:85ac:5875:b51a] (unknown
 [IPv6:2001:7b8:3a7:0:d87c:85ac:5875:b51a])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id AACDD5C44;
 Mon, 21 Oct 2013 08:46:12 +0200 (CEST)
Content-Type: multipart/signed;
 boundary="Apple-Mail=_BF3C372F-3194-4C51-A838-39B4067EB9DB";
 protocol="application/pgp-signature"; micalg=pgp-sha1
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
Subject: Re: gperf/src/options.cc -- quiesce clang warnings
 -Wlogical-op-parentheses
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <1382327452.2610.5.camel@localhost>
Date: Mon, 21 Oct 2013 08:46:14 +0200
Message-Id: <95F9CC95-2A34-40C6-A04A-3B2360B6E4DB@FreeBSD.org>
References: <1382327452.2610.5.camel@localhost>
To: sbruno@freebsd.org
X-Mailer: Apple Mail (2.1510)
Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Oct 2013 06:46:14 -0000


--Apple-Mail=_BF3C372F-3194-4C51-A838-39B4067EB9DB
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On Oct 21, 2013, at 05:50, Sean Bruno <sean_bruno@yahoo.com> wrote:
> gperf has some clang warnings that seem to be harmless, but annoying
> regarding some of the logical operations around detecting ascii chars:
> 
> c++ -O2 -pipe -I/usr/obj/usr/src/tmp/legacy/usr/include -Wno-c
> ++11-extensions -I/usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/lib
> -I/usr/src/gnu/usr.bin/g
> perf -c /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/options.cc
> /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/options.cc:284:27:
> warning: '&&' within '||' [-Wlogical-op-parentheses]
>          if (*arg >= 'A' && *arg <= 'Z' || *arg >= 'a' && *arg <= 'z')
>              ~~~~~~~~~~~~^~~~~~~~~~~~~~ ~~

For contributed code, let's just turn the warnings off instead.  There
is almost no end to the amount of work you could spend on fixing
warnings in GNU code... :-)

-Dimitry


--Apple-Mail=_BF3C372F-3194-4C51-A838-39B4067EB9DB
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.20 (Darwin)

iEYEARECAAYFAlJkzbYACgkQsF6jCi4glqMHHgCfScwz1Vmplg6vbaHJ98A9oAux
+AQAnRVv18jjeA9pxgTlG8WPNqFIXcZE
=b2jA
-----END PGP SIGNATURE-----

--Apple-Mail=_BF3C372F-3194-4C51-A838-39B4067EB9DB--