From nobody Thu Oct 20 14:38:11 2022 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MtVZX19mmz4fTj2 for ; Thu, 20 Oct 2022 14:38:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MtVZX09W1z40Tk for ; Thu, 20 Oct 2022 14:38:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MtVZW6P4Gzv0B for ; Thu, 20 Oct 2022 14:38:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 29KEcBgu048443 for ; Thu, 20 Oct 2022 14:38:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 29KEcBlK048442 for net@FreeBSD.org; Thu, 20 Oct 2022 14:38:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 265588] [TCP] - tcp send a retransmission identical sequence number packet with different payload Date: Thu, 20 Oct 2022 14:38:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mizhka@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_severity Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666276692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WGDcCTBsM9xijtz0kzniHAeugvtNIFexsFFByhddugU=; b=kedPcS2nfYZbGSY8rZ09C9gh5iFIKPRESdtwLnO0NwnZuwCcTbDpnVubgQwhoDbNF03sw2 50Fh37jWGc/VeSNn5+MoXH1T3UtMTLEuMSzdxku5Pgyc/1ssctk2NjqmukdKkOiXWd00ej cir7syIx8XLR8AeM91ujPCrZrt2OA/HaCZy5eQ/2oWnqqMPU0oOZhHmZKVzL/+LT0kfD9K rk3pMAsM/GeV+PiB4VgjLbEHGv08XPGzMGNhR/DepR/I9fYN83BYFCRt1Bu3jo8yza/H09 OmeeOhg42ehK7rt1IaMoT+Wisl6UPw+zWfzheR1R8pAeFY9NYM/ofvalMLtlHQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666276692; a=rsa-sha256; cv=none; b=Nv3r0aYA71EQg4u+QbdxKT3cngOqBSuUtJUfRLYsc3KGg+q/pdSWeZMAp/zaV+eDD9JYbY Xn/JIzKhHT0ln8OWemIcVPLD3DUkHdx0OW9PI4yELrXApVoZv7ZNY4aG0dhw3/KEGNMjsO PHaf5NdN+Y4P+VwG3F0PNvSi/+NrQh05Db/Zj5I2S5lCzYAhTgA96qYklcIk+W5KQfkiv6 ft8GBe+bCJmTOAebiU6fZWwH8cK1aDimhkGl9k9HoRQHzG2NUE4psa09OhfR8QXrDZ3K5o H4wfqtF+59azfJJv+zP56ONS4JqtlIgpYrYvIRvPygilxtAzK3s5cKDIbotNxg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265588 Michael Zhilin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mizhka@FreeBSD.org Severity|Affects Only Me |Affects Some People --- Comment #19 from Michael Zhilin --- Hi, I've found same defect on 13.1-RELEASE with fetching of packages via HTTP protocol.=20 Shortly speaking, https://reviews.freebsd.org/D36046 is fix for this bug. I= t's already committed to stable/13 and main.=20 The issue is not reproduced on 14-current and stable/13. My setup is following: - FreeBSD guest in data center in same town (with poudriere and HTTP nginx) - I use VPN & WiFi to access it Sometimes packets are lost and server may start retransmission of several packets with same payload but with different sequence numbers. Sometimes, b= ut not always. Then it sends same payload third time with correct payload. :/ For testing I download 500MiB file 4 times: fetch -q http://192.168.20.12:8000/gcc11-11.3.0_1.pkg && md5 gcc11-11.3.0_1= .pkg=20 fetch -q http://192.168.20.12:8000/gcc11-11.3.0_1.pkg && md5 gcc11-11.3.0_1= .pkg=20 fetch -q http://192.168.20.12:8000/gcc11-11.3.0_1.pkg && md5 gcc11-11.3.0_1= .pkg=20 fetch -q http://192.168.20.12:8000/gcc11-11.3.0_1.pkg && md5 gcc11-11.3.0_1= .pkg=20 If all checksums are correct, kernel is good.=20 I've bisected it to commit: https://github.com/freebsd/freebsd-src/commit/c21b7b55bea2cc2bf3b420c70a901= 8e703ed6f00 commit c21b7b55bea2cc2bf3b420c70a9018e703ed6f00 Author: Richard Scheffenegger Date: Wed Aug 31 14:49:25 2022 +0200 tcp: finish SACK loss recovery on sudden lack of SACK blocks While a receiver should continue sending SACK blocks for the duration of a SACK loss recovery, if for some reason the TCP options no longer contain these SACK blocks, but we already started maintaining the Scoreboard, keep on handling incoming ACKs (without SACK) as belonging to the SACK recovery. Reported by: thj Reviewed by: tuexen, #transport MFC after: 2 weeks Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D36046 sys/netinet/tcp_input.c | 39 ++++++++++++++++++++++----------------- 1 file changed, 22 insertions(+), 17 deletions(-) Many thanks to Gleb and Richard! --=20 You are receiving this mail because: You are the assignee for the bug.=