From owner-cvs-src-old@FreeBSD.ORG Mon Aug 30 16:30:38 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76B8F1065672 for ; Mon, 30 Aug 2010 16:30:38 +0000 (UTC) (envelope-from jh@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 63FF28FC08 for ; Mon, 30 Aug 2010 16:30:38 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o7UGUcE9097346 for ; Mon, 30 Aug 2010 16:30:38 GMT (envelope-from jh@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o7UGUcl7097345 for cvs-src-old@freebsd.org; Mon, 30 Aug 2010 16:30:38 GMT (envelope-from jh@repoman.freebsd.org) Message-Id: <201008301630.o7UGUcl7097345@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jh@repoman.freebsd.org using -f From: Jaakko Heinonen Date: Mon, 30 Aug 2010 16:30:18 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c src/sys/kern kern_exec.c subr_acl_nfs4.c subr_acl_posix1e.c vfs_subr.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2010 16:30:38 -0000 jh 2010-08-30 16:30:18 UTC FreeBSD src repository Modified files: sys/cddl/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c sys/kern kern_exec.c subr_acl_nfs4.c subr_acl_posix1e.c vfs_subr.c Log: SVN rev 212002 on 2010-08-30 16:30:18Z by jh execve(2) has a special check for file permissions: a file must have at least one execute bit set, otherwise execve(2) will return EACCES even for an user with PRIV_VFS_EXEC privilege. Add the check also to vaccess(9), vaccess_acl_nfs4(9) and vaccess_acl_posix1e(9). This makes access(2) to better agree with execve(2). Because ZFS doesn't use vaccess(9) for VEXEC, add the check to zfs_freebsd_access() too. There may be other file systems which are not using vaccess*() functions and need to be handled separately. PR: kern/125009 Reviewed by: bde, trasz Approved by: pjd (ZFS part) Revision Changes Path 1.69 +11 -4 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c 1.358 +8 -8 src/sys/kern/kern_exec.c 1.7 +20 -2 src/sys/kern/subr_acl_nfs4.c 1.59 +8 -2 src/sys/kern/subr_acl_posix1e.c 1.791 +6 -0 src/sys/kern/vfs_subr.c