From owner-svn-src-head@FreeBSD.ORG  Fri Feb  1 18:30:42 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 63F8D818;
 Fri,  1 Feb 2013 18:30:42 +0000 (UTC) (envelope-from kib@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 52835817;
 Fri,  1 Feb 2013 18:30:42 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r11IUgZW018637;
 Fri, 1 Feb 2013 18:30:42 GMT (envelope-from kib@svn.freebsd.org)
Received: (from kib@localhost)
 by svn.freebsd.org (8.14.5/8.14.5/Submit) id r11IUgEJ018636;
 Fri, 1 Feb 2013 18:30:42 GMT (envelope-from kib@svn.freebsd.org)
Message-Id: <201302011830.r11IUgEJ018636@svn.freebsd.org>
From: Konstantin Belousov <kib@FreeBSD.org>
Date: Fri, 1 Feb 2013 18:30:42 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r246219 - head/sys/fs/msdosfs
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Feb 2013 18:30:42 -0000

Author: kib
Date: Fri Feb  1 18:30:41 2013
New Revision: 246219
URL: http://svnweb.freebsd.org/changeset/base/246219

Log:
  The MSDOSFSMNT_WAITONFAT flag is bogus and broken.  It does less than
  track the MNT_SYNCHRONOUS flag.  It is set to the latter at mount time
  but not updated by MNT_UPDATE.
  
  Use MNT_SYNCHRONOUS to decide to write the FAT updates syncrhonously.
  
  Submitted by:	bde
  MFC after:	1 week

Modified:
  head/sys/fs/msdosfs/msdosfs_fat.c

Modified: head/sys/fs/msdosfs/msdosfs_fat.c
==============================================================================
--- head/sys/fs/msdosfs/msdosfs_fat.c	Fri Feb  1 18:25:53 2013	(r246218)
+++ head/sys/fs/msdosfs/msdosfs_fat.c	Fri Feb  1 18:30:41 2013	(r246219)
@@ -379,7 +379,7 @@ updatefats(pmp, bp, fatbn)
 				((u_int8_t *)bpn->b_data)[3] |= 0x80;
 			else if (cleanfat == 32)
 				((u_int8_t *)bpn->b_data)[7] |= 0x08;
-			if (pmp->pm_flags & MSDOSFSMNT_WAITONFAT)
+			if (pmp->pm_mountp->mnt_flag & MNT_SYNCHRONOUS)
 				bwrite(bpn);
 			else
 				bdwrite(bpn);
@@ -389,7 +389,7 @@ updatefats(pmp, bp, fatbn)
 	/*
 	 * Write out the first (or current) fat last.
 	 */
-	if (pmp->pm_flags & MSDOSFSMNT_WAITONFAT)
+	if (pmp->pm_mountp->mnt_flag & MNT_SYNCHRONOUS)
 		bwrite(bp);
 	else
 		bdwrite(bp);