From owner-cvs-all@FreeBSD.ORG  Tue Nov 30 20:39:19 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0B72016A4CE; Tue, 30 Nov 2004 20:39:19 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 623A243D39; Tue, 30 Nov 2004 20:39:18 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iAUKdF0x055551;
	Tue, 30 Nov 2004 21:39:15 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Ruslan Ermilov <ru@freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 30 Nov 2004 22:36:43 +0200."
             <20041130203643.GB20833@ip.net.ua> 
Date: Tue, 30 Nov 2004 21:39:15 +0100
Message-ID: <55550.1101847155@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@freebsd.org
cc: Doug Barton <DougB@dougbarton.net>
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sbin/mount mntopts.h mount.8 mount.c
	src/sbin/mount_std mount_std.8 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Nov 2004 20:39:19 -0000

In message <20041130203643.GB20833@ip.net.ua>, Ruslan Ermilov writes:

>> I tried to find my copy of "Bitmaps for dummies" to check what
>> you're saying but I can't find it right now, still, I'm very sure
>> that you are wrong, I just don't have the book to prove it.
>> 
>> Most operations on MNT_* are "bitwise OR" and a zero is perfectly OK.
>> 
>Well, definitely *not* in sbin/mount/mount.c.

The problem in mount.c is that it terminates the search of optnames[]
if the option is zero.  That would more properly have been fixed by
terminating if the name string was NULL.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.