From owner-freebsd-ports-bugs@freebsd.org Fri Jun 2 11:21:05 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 378CFBF5A42 for ; Fri, 2 Jun 2017 11:21:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2599C844E4 for ; Fri, 2 Jun 2017 11:21:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v52BL5wh098096 for ; Fri, 2 Jun 2017 11:21:05 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 219724] www/fcgiwrap rc script no check for pid file at onerestart Date: Fri, 02 Jun 2017 11:21:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: bblister@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2017 11:21:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219724 Bug ID: 219724 Summary: www/fcgiwrap rc script no check for pid file at onerestart Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: bblister@gmail.com 10.3-RELEASE-p18 FreeBSD 10.3-RELEASE-p18 #0: Tue Apr 11 10:31:00 UTC 2017= =20=20=20=20 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 fcgiwrap-1.1.0_5=20 The startup script /usr/local/etc/rc.d/fcgiwrap at the function fcgiwrap_stop() finds the pid file of the processed without checking if pidfile exists: fcgiwrap_pgrp=3D$(/bin/ps -o ppid=3D $(cat ${pidfile})) Thus when the pidfile does not exist (for example, at the startup if you is= sue /usr/local/etc/rc.d/fcgiwrap onerestart (and no pid file exist) then we have an output that contains the PPID 1 like the following: /bin/ps -o ppid=3D $(cat /var/run/fcgiwrap/fcgiwrap.pid)=20 cat: /var/run/fcgiwrap/fcgiwrap.pid: No such file or directory=20 72303=20 1=20 71730=20 72092=20 1=20 1=20 1=20 and then using two lines after this a command kill -TERM -- -${fcgiwrap_pg= rp}=20 terminates all these pids.=20 But, PID 1 is the /sbin/init and according to init(8)=20 ...init will signal the original (PID 1) init as follows:=20 ....=20 1 SIGTERM Go to single-user mode=20 So the fastcgiwrap sends SIGTERM to /sbin/init and then systems reverts to single user mode.=20 The fix is to first check the existence of the file, like=20 if [ -f ${pidfile} ] ; then ....=20 BB. --=20 You are receiving this mail because: You are the assignee for the bug.=