Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Feb 2012 15:23:12 -0800
From:      Doug Barton <dougb@FreeBSD.org>
To:        Andrew Thompson <thompsa@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r232080 - in head: share/man/man4 sys/net
Message-ID:  <4F46CA60.6030409@FreeBSD.org>
In-Reply-To: <201202232156.q1NLurPU025054@svn.freebsd.org>
References:  <201202232156.q1NLurPU025054@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
First, I'm always glad to see devs updating the documentation, so please
don't take this as in any way being critical, just trying to help. :)


On 02/23/2012 13:56, Andrew Thompson wrote:
> Modified: head/share/man/man4/lagg.4
> ==============================================================================
> --- head/share/man/man4/lagg.4	Thu Feb 23 21:54:04 2012	(r232079)
> +++ head/share/man/man4/lagg.4	Thu Feb 23 21:56:53 2012	(r232080)
> @@ -142,10 +142,12 @@ and
>  modes will use the RSS hash from the network card if available to avoid
>  computing one, this may give poor traffic distribution if the hash is invalid
>  or uses less of the protocol header information.
> -Local hash computation can be forced by setting the
> +Local hash computation can be forced per interface by setting the

This is a great example of why we use short lines in the man page
sources. It allows people to come along later and add text without
having to make changes to multiple lines.

>  .Va net.link.lagg.X.use_flowid
>  .Xr sysctl 8
> -variable to zero where X is the interface number.
> +variable to zero where X is the interface number, the default for
> +new interfaces is set via
> +.Va net.link.lagg.default_use_flowid .

If adding a comma there was the right change the new clause should still
have started on the next line, for the reason described above. However,
what you added is actually a sentence that can/should stand on its own.


hth,

Doug

-- 

	It's always a long day; 86400 doesn't fit into a short.

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F46CA60.6030409>