From owner-svn-src-all@FreeBSD.ORG Fri Apr 27 14:23:16 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C334A106564A; Fri, 27 Apr 2012 14:23:16 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id A7A488FC0A; Fri, 27 Apr 2012 14:23:15 +0000 (UTC) Received: by lbbgm6 with SMTP id gm6so727922lbb.13 for ; Fri, 27 Apr 2012 07:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=da2KH26WtOl/gIOQRb2ZPXRqwl1po7QflP06pfglVhE=; b=sFE02YDHw+bbKcOWpm0FZnwc0bqXg2Fledy5TJ49ewLGEYoAqCW5aknR2a4anhbHNT Jh/QDJurN/ym39g20pGgUrzoa3XeQ1DTBffm5KFDLH4sh+S+ysDYBrEXuuny3ceuAfz0 jKPwCDw0NI58Eagfyc1DSQybneRPqMRL6V4hBtQSUIZqgtm6F1oFMCi6N+pykaZUjwM4 dKk79R+oXo/AbVrmPNnchVCa4iV/14EPbXNZkuBzaHK5QH4s8gbyJUT+dYeqr7YV0m8G w+3ohtCo9CnUxUPCYyuoTxXSmhGNmIyFMpMGZ5jGOSfwAIyP2wQKywIi6t6XxuWQU/lK BtNA== MIME-Version: 1.0 Received: by 10.152.132.166 with SMTP id ov6mr11728267lab.35.1335536594648; Fri, 27 Apr 2012 07:23:14 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.63.146 with HTTP; Fri, 27 Apr 2012 07:23:14 -0700 (PDT) In-Reply-To: <201204271020.59067.jhb@freebsd.org> References: <201204262024.q3QKOPA6067287@svn.freebsd.org> <201204270740.43912.jhb@freebsd.org> <201204271020.59067.jhb@freebsd.org> Date: Fri, 27 Apr 2012 15:23:14 +0100 X-Google-Sender-Auth: YmBOr5AAmb_D9mjcbN-PzDZN3l8 Message-ID: From: Attilio Rao To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r234723 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98 sparc64/include sparc64/sparc64 x86/x86 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2012 14:23:16 -0000 2012/4/27, John Baldwin : > On Friday, April 27, 2012 9:55:41 am Attilio Rao wrote: >> 2012/4/27, John Baldwin : >> > On Thursday, April 26, 2012 4:24:25 pm Attilio Rao wrote: >> >> Author: attilio >> >> Date: Thu Apr 26 20:24:25 2012 >> >> New Revision: 234723 >> >> URL: http://svn.freebsd.org/changeset/base/234723 >> >> >> >> Log: >> >> Clean up the intr* MD KPI from the SMP dependency, removing a cause >> >> of >> >> discrepancy between modules and kernel, but deal with SMP >> >> differences >> >> within the functions themselves. >> >> >> >> As an added bonus this also helps in terms of code readability. >> > >> > Hmm, this should not have affected anything with modules as no modules >> > should have ever called this. Also, making intr_bind() available for >> > UP >> > kernels on x86 is largely pointless. It's only caller is already >> > conditional >> > in sys/x86/x86/nexus.c: >> >> It doesn't mean that there couldn't be an user in the future of this >> KPI in terms of thirdy part modules. >> These functions are part of the public KPI and we speak a lot about >> making our KPI as less as dependent by compiling options so I don't >> really see why you are not happy about this. >> >> If the function (intr_bind() included) is part of the public KPI it >> can be called by thirdy part modules too. > > No! intr_bind() is _NOT_ part of the public KPI. The public KPI is > bus_intr_bind() which accepts a struct resource, which is the approved > handle for interrupt resources in drivers and other modules. It is accessible from machine/intr_machdep.h so *it is* part of the public KPI by definition. However I won't argue further and will change it as you request, I have enough of no-sense requests on this simple change. Attilio -- Peace can only be achieved by understanding - A. Einstein