From owner-dev-commits-src-all@freebsd.org Wed Jun 9 13:45:40 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B497064E4D8 for ; Wed, 9 Jun 2021 13:45:40 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mail.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G0Szl0L4Zz4bLZ; Wed, 9 Jun 2021 13:45:38 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1623246336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TOzZGthM6zy+V/ppuUNSiAvtlMkRYBBN35ZBp9O1rSA=; b=nxYTVsWiU6B+gvWt6qExDpG4cSUKtWfG2FP8QgoZqB799k02zj+vi/bVhABhiVySGnflyf 6VGCNqNPVddieBt5S5Lwa3zhiGtFvyjyfDF/leQrYjQSdcJ2z3H2OXhWDDGRN6HvI1Y4iv ENSpl2/tRt+vWgcEpfQAyiFGxep0JSI= Received: from skull.home.blih.net (lfbn-idf2-1-644-4.w86-247.abo.wanadoo.fr [86.247.100.4]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 6d667015 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 9 Jun 2021 13:45:36 +0000 (UTC) Date: Wed, 9 Jun 2021 15:45:33 +0200 From: Emmanuel Vadot To: Cy Schubert Cc: Cy Schubert , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org Subject: Re: git: 40c7ff83e74e - vendor/wpa - wpa: Import wpa_supplicant/hostapd commit e8662e9d4 Message-Id: <20210609154533.4931d8af823b95384b097650@bidouilliste.com> In-Reply-To: <202106091317.159DH9U5013332@slippy.cwsent.com> References: <202106031638.153GcGhh069766@gitrepo.freebsd.org> <20210609090415.507c477968bce2efce9e9ff8@bidouilliste.com> <202106091317.159DH9U5013332@slippy.cwsent.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4G0Szl0L4Zz4bLZ X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=nxYTVsWi; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [0.50 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; FREEFALL_USER(0.00)[manu]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MV_CASE(0.50)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_MEDIUM(1.00)[1.000]; SPAMHAUS_ZRD(0.00)[212.83.155.74:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(1.00)[0.999]; DKIM_TRACE(0.00)[bidouilliste.com:+]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; NEURAL_HAM_LONG(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[212.83.155.74:from]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-all] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 13:45:40 -0000 On Wed, 09 Jun 2021 06:17:09 -0700 Cy Schubert wrote: > In message <20210609090415.507c477968bce2efce9e9ff8@bidouilliste.com>, > Emmanuel > Vadot writes: > > On Thu, 3 Jun 2021 16:38:16 GMT > > Cy Schubert wrote: > > > > > The branch vendor/wpa has been updated by cy: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=40c7ff83e74eabba5a7e2caefeea12 > > 372b2d3f9a > > > > > > commit 40c7ff83e74eabba5a7e2caefeea12372b2d3f9a > > > Author: Cy Schubert > > > AuthorDate: 2021-06-03 16:15:01 +0000 > > > Commit: Cy Schubert > > > CommitDate: 2021-06-03 16:15:01 +0000 > > > > > > wpa: Import wpa_supplicant/hostapd commit e8662e9d4 > > > > > > This is the June update to vendor/wpa committed upstream 2021/06/03. > > > > Hi cy@ > > > > Don't know if it is this commit or something else yet but I'm seeing > > weird behavior from a recent head. > > wpa_supplicant abort with SIGBUS just after connecting to my wireless > > network. I'm still connected but this stopped working after a while (I > > guess when the supplicant would need to do some stuff with the AP or > > something). > > From dmesg just after running service netif restart: > > lo0: link state changed to DOWN > > wlan0: link state changed to DOWN > > wlan0: Ethernet address: bc:54:2f:4b:d1:dd > > lo0: link state changed to UP > > wlan0: link state changed to UP > > pid 69593 (wpa_supplicant), jid 0, uid 0: exited on signal 10 (core > > dumped) > > > > Reading symbols from /usr/sbin/wpa_supplicant... > > Reading symbols from /usr/lib/debug//usr/sbin/wpa_supplicant.debug... > > [New LWP 112604] > > Core was generated by `/usr/sbin/wpa_supplicant -s -B -i wlan0 -c /etc/wpa_su > > pplicant.conf -D bsd -P /v'. > > Program terminated with signal SIGBUS, Bus error. > > #0 0x00000000010eaf7f in wpa_sm_set_rekey_offload (sm=0x801e12700) at /usr/l > > ocal/poudriere/jails/wipbsd/usr/src/contrib/wpa/src/rsn_supp/wpa_i.h:304 > > 304 /usr/local/poudriere/jails/wipbsd/usr/src/contrib/wpa/src/rsn_supp/wp > > a_i.h: No such file or directory. > > (gdb) bt > > #0 0x00000000010eaf7f in wpa_sm_set_rekey_offload (sm=0x801e12700) at /usr/l > > ocal/poudriere/jails/wipbsd/usr/src/contrib/wpa/src/rsn_supp/wpa_i.h:304 > > #1 wpa_supplicant_process_3_of_4 (sm=0x801e12700, key=, ver=< > > optimized out>, key_data=, key_data_len=) > > at /usr/local/poudriere/jails/wipbsd/usr/src/contrib/wpa/src/rsn_supp/wpa > > .c:1572 > > #2 wpa_sm_rx_eapol (sm=, src_addr=, buf= > ized out>, len=) > > at /usr/local/poudriere/jails/wipbsd/usr/src/contrib/wpa/src/rsn_supp/wpa > > .c:2434 > > #3 0x00000000010e372e in l2_packet_receive (sock=, eloop_ctx= > > 0x801e286e0, sock_ctx=) > > at /usr/local/poudriere/jails/wipbsd/usr/src/contrib/wpa/src/l2_packet/l2 > > _packet_freebsd.c:98 > > #4 0x0000000001112b23 in eloop_sock_table_dispatch (table=, f > > ds=0x801e44080) at /usr/local/poudriere/jails/wipbsd/usr/src/contrib/wpa/src/ > > utils/eloop.c:600 > > #5 eloop_run () at /usr/local/poudriere/jails/wipbsd/usr/src/contrib/wpa/src > > /utils/eloop.c:1223 > > #6 0x00000000010af228 in wpa_supplicant_run (global=, global@ > > entry=0x801e2d000) > > at /usr/local/poudriere/jails/wipbsd/usr/src/contrib/wpa/wpa_supplicant/w > > pa_supplicant.c:6526 > > #7 0x000000000109ab6c in main (argc=, argv=) a > > t /usr/local/poudriere/jails/wipbsd/usr/src/contrib/wpa/wpa_supplicant/main.c > > :397 > > > > I'll try to revert the update later this week but if you have any idea in th > > e mean time. > > Hi Emmanuel, > > The commit you quote was only to the vendor branch which has not landed in > main yet. However the SIGBUS you have been experiencing, a SIBGUS at line > 304 of wpa_i.h, caused by 25ecdc7d52770caf1c9b44b5ec11f468f6b636f3 and > fixed by the following commit: > > commit 9a0f82285322a338548d13fcda07e1d574301190 > Author: Cy Schubert > Date: Wed Jun 2 12:46:02 2021 -0700 > > wpa: Fix a SIGBUS error in wpa_sm_set_rekey_offload > > Incorrectly linked built-in wpa functions resulted in overwriting > sm->ctx->set_rekey_offload with garbage. It was initialized correctly > however it changed after wpa_supplicant became a daemon. > > No SIGBUS violations reported by dhw@ were experienced during testing > of the original commit by msyelf or philip@. > > Reported by: dhw > Tested by: dhw > MFC after: 2 months > X-MFC with: 25ecdc7d52770caf1c9b44b5ec11f468f6b636f3 > > If you already have 9a0f82285322a338548d13fcda07e1d574301190 applied and do > -DWITHOUT_CLEAN builds and still have the SIGBUS, rm -r > /usr/obj/${ARCH}/usr.sbin/wpa will remove incorrectly built .a files and > rebuild. They will rebuild correctly and the SIBGUS will resolve. > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > The need of the many outweighs the greed of the few. > > Ok, will try a build without WITHOUT_CLEAN=y and let you know if I still have problems after. Thanks, -- Emmanuel Vadot