From owner-svn-src-head@freebsd.org  Thu Nov 24 19:08:11 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3AB2AC533B1;
 Thu, 24 Nov 2016 19:08:11 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0C781E3;
 Thu, 24 Nov 2016 19:08:10 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 62F8510A998;
 Thu, 24 Nov 2016 14:08:03 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= <des@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r309109 - head/lib/libutil
Date: Thu, 24 Nov 2016 11:06:04 -0800
Message-ID: <2600117.GH2pUSAs7N@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; )
In-Reply-To: <201611241450.uAOEoLA5079215@repo.freebsd.org>
References: <201611241450.uAOEoLA5079215@repo.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Thu, 24 Nov 2016 14:08:03 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Nov 2016 19:08:11 -0000

On Thursday, November 24, 2016 02:50:21 PM Dag-Erling Sm=F8rgrav wrote:=

> Author: des
> Date: Thu Nov 24 14:50:21 2016
> New Revision: 309109
> URL: https://svnweb.freebsd.org/changeset/base/309109
>=20
> Log:
>   Add a warning against modifying this code without understanding it,=
 and
>   an example of how not to make it more portable.  I've had this lyin=
g
>   around uncommitted since 2009...

While I think the sentiment is correct, I would suggest adjusting the c=
omment
as some folks may not get the sarcasm on first blush.  Even though it s=
omewhat
duplicates the revision log, I think it would be useful to expand the c=
omment
to list some of the "obvious" improvements to this function that actual=
ly
break it along with a brief explanation of the breakage each of these c=
hanges
cause.  In particular, the code here doesn't explain why close-on-exec =
would
be bad, but a comment as I've described would.

--=20
John Baldwin