From owner-cvs-all@FreeBSD.ORG Tue Jun 15 21:19:41 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA3A416A4CF; Tue, 15 Jun 2004 21:19:41 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F60843D5C; Tue, 15 Jun 2004 21:19:41 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.0.12] (g4.samsco.home [192.168.0.12]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i5FLMCqC012572; Tue, 15 Jun 2004 15:22:13 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <40CF67AA.50600@freebsd.org> Date: Tue, 15 Jun 2004 15:18:34 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040514 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Gordon Tetlow References: <200406132212.i5DMC3b9075832@repoman.freebsd.org> <20040614011012.H1600@newtrinity.zeist.de> <20040614010854.GA98360@dragon.nuxi.com> <40CCFCDF.4040303@freebsd.org> <20040615160107.GT10016@spiff.melthusia.org> In-Reply-To: <20040615160107.GT10016@spiff.melthusia.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: src-committers@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: obrien@freebsd.org cc: Joseph Dunn Subject: Re: cvs commit: src/sys/dev/sound/pci emu10k1.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2004 21:19:42 -0000 Gordon Tetlow wrote: > On Sun, Jun 13, 2004 at 07:18:23PM -0600, Scott Long wrote: > >>>Possibly. Still doesn't mean we shouldn't add the PCI ID to help people >>>farther along in determining if it really works or not. If we get >>>reliable failure reports in 5-CURRENT (which has a much updated driver >> >>>from 5.2.1) we can print out an error message in the probe. >> >>Well, this is kinda like finding a new Adaptec ID and adding it to the >>ahc driver just because it's there, regardless of whether the driver can >>talk to the chip. > > > I would also argue that storage subsystems and sound cards are two very > different class of devices. We can afford to be a little overzealous with > sound hardware. If it doesn't work, it's not the end of the world. If a > storage subsystem that is probed doesn't work (or worse, silently fails > in subtle ways), that's much worse. > > -gordon It's fine to put an unknown ID into a driver to do local testing and discovery. It's less acceptable to commit that change to FreeBSD CVS without knowing what it does and what impact it has. Anyways, this has been kicked around enough and I believe that David already said that he will back out the change. Scott