From owner-freebsd-bugs Wed Aug 14 16:20: 7 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C54F37B400 for ; Wed, 14 Aug 2002 16:20:04 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0CE3343E4A for ; Wed, 14 Aug 2002 16:20:04 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7ENK3JU068346 for ; Wed, 14 Aug 2002 16:20:03 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7ENK3Kw068345; Wed, 14 Aug 2002 16:20:03 -0700 (PDT) Date: Wed, 14 Aug 2002 16:20:03 -0700 (PDT) Message-Id: <200208142320.g7ENK3Kw068345@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Bruce Evans Subject: Re: kern/40636: PCI devices don't share IRQs. Reply-To: Bruce Evans Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR kern/40636; it has been noted by GNATS. From: Bruce Evans To: Matthew Emmerton Cc: freebsd-gnats-submit@FreeBSD.org, , Subject: Re: kern/40636: PCI devices don't share IRQs. Date: Thu, 15 Aug 2002 09:20:23 +1000 (EST) On Wed, 14 Aug 2002, Matthew Emmerton wrote: > How is this a duplicate of kern/20523? That PR deals with multi-port PCI > serial devices, where this just deals with single-port PCI serial devices -- > unless it's just a generalization. > > The originator of kern/40636 has not seen any performance problems with my > patch, so unless sharing intr_fast (whatever the heck that is -- I can't > find any mention of that in the sio.c file) is some very bad thing to do, I > don't see a problem with my patch. > > Can someone please clarify? See my earlier reply. (intr_fast is a misspelling of INTR_FAST in -current and INTR_TYPE_FAST in older versions. Not using it tends to give you silo overflows. I think the patch is better than nothing but it only helps if the sio device happens to be attached after another device that shares the irq. The INTR_*_FAST BUS_SETUP_INTR() call must be removed to get deterministic behaviour and doing that clearly breaks fast interrupts always.) Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message