From owner-freebsd-bugs@FreeBSD.ORG  Tue Jun 28 16:10:09 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EB1281065674
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 28 Jun 2011 16:10:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id AEDB78FC0C
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 28 Jun 2011 16:10:09 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5SGA9bW016604
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 28 Jun 2011 16:10:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5SGA9NN016600;
	Tue, 28 Jun 2011 16:10:09 GMT (envelope-from gnats)
Resent-Date: Tue, 28 Jun 2011 16:10:09 GMT
Resent-Message-Id: <201106281610.p5SGA9NN016600@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Robert Millan <rmh@debian.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 88B49106566B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 28 Jun 2011 16:01:17 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 790DD8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 28 Jun 2011 16:01:17 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p5SG1Hql057770
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Jun 2011 16:01:17 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p5SG1Hln057769;
	Tue, 28 Jun 2011 16:01:17 GMT (envelope-from nobody)
Message-Id: <201106281601.p5SG1Hln057769@red.freebsd.org>
Date: Tue, 28 Jun 2011 16:01:17 GMT
From: Robert Millan <rmh@debian.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/158398: <geom/geom.h> includes <sys/sbuf.h> gratuitously
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jun 2011 16:10:10 -0000


>Number:         158398
>Category:       misc
>Synopsis:       <geom/geom.h> includes <sys/sbuf.h> gratuitously
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 28 16:10:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Robert Millan
>Release:        Debian GNU/kFreeBSD "sid"
>Organization:
>Environment:
>Description:
<geom/geom.h> includes <sys/sbuf.h> but doesn't really need it, since struct sbuf s treated as an opaque struct in this file.

Please consider removing this include, in Debian this makes life easier since libsbuf is a separate package and may not be available to <geom/geom.h> users.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- a/sys/geom/geom.h
+++ b/sys/geom/geom.h
@@ -43,7 +43,6 @@
 #include <sys/sx.h>
 #include <sys/queue.h>
 #include <sys/ioccom.h>
-#include <sys/sbuf.h>
 #include <sys/module.h>
 
 struct g_class;


>Release-Note:
>Audit-Trail:
>Unformatted: