From owner-cvs-all Tue Oct 8 13: 3: 5 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C0F5537B4F8; Tue, 8 Oct 2002 13:03:01 -0700 (PDT) Received: from rhadamanth.submonkey.net (pc1-cdif2-4-cust210.cdf.cable.ntl.com [80.4.10.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB51C43E3B; Tue, 8 Oct 2002 13:03:00 -0700 (PDT) (envelope-from setantae@submonkey.net) Received: from setantae by rhadamanth.submonkey.net with local (Exim 4.10) id 17z0ZH-000MxD-00; Tue, 08 Oct 2002 21:02:59 +0100 Date: Tue, 8 Oct 2002 21:02:59 +0100 From: Ceri Davies To: =?unknown-8bit?Q?S=F8ren?= Schmidt Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-pci.c Message-ID: <20021008200259.GA88145@submonkey.net> Mail-Followup-To: Ceri Davies , =?unknown-8bit?Q?S=F8ren?= Schmidt , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200210081825.g98IPAf6076545@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=unknown-8bit Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200210081825.g98IPAf6076545@freefall.freebsd.org> X-message-flag: All your linuxconf-configured redhat are belong to us. User-Agent: Mutt/1.5.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Oct 08, 2002 at 11:25:10AM -0700, Søren Schmidt wrote: > sos 2002/10/08 11:25:10 PDT > > Modified files: > sys/dev/ata ata-pci.c > Log: > Fix for the panic when using a Promise TX2. > > The problem is that the code does a check for the granparent of > the Promise chip, if this is a bridge of the right type, we have > a TX4 on our hands, and need to handle that ones "issues". > Now the grandparent check cause subtle bugs in the newbus system, > mainly that pci_get_devid doesn't return an error value. > This patch works around the issue by using BUS_READ_IVAR() instead. Thank you! Ceri -- you can't see when light's so strong you can't see when light is gone To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message