Date: Sun, 21 May 2023 14:06:12 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 269566] New port: lang/mlkit Message-ID: <bug-269566-7788-vbUMJYylLU@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-269566-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-269566-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269566 --- Comment #10 from Robert Clausecker <fuz@FreeBSD.org> --- (In reply to serpent7776 from comment #9) > Maybe the TEST option should be removed altogether. The intent was to jus= t run > tests provided by mlkit. I removed test related files from pkg-plis= t, because I > don't believe they are necessary to be in the package. The correct way is to only add these files to the package if the TEST optio= n is set. See =C2=A7 8.1 Porter's Handbook for how to do that. You can at the = same time hook up the test suite to the do-test target, but do it independently of the TEST option. > I'm not sure what to do about the canfigure.ac file. Should I just patch = it to hardcode some values instead of querying git/date commands? Yes, that works. Bonus points if it includes PKGVERSION somewhere and that= it was built by FreeBSD ports and who the maintainer is and that sort of stuff= .=20 You can use REINPLACE_CMD for such dynamic replacements. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-269566-7788-vbUMJYylLU>