Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 May 2013 01:11:27 -0400
From:      Glen Barber <gjb@FreeBSD.org>
To:        Stefan Esser <se@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r250972 - head/usr.bin/patch
Message-ID:  <20130525051127.GP1756@glenbarber.us>
In-Reply-To: <201305241854.r4OIsqdU043683@svn.freebsd.org>
References:  <201305241854.r4OIsqdU043683@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--FYef6pHvFBuPZp1D
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 24, 2013 at 06:54:52PM +0000, Stefan Esser wrote:
> Author: se
> Date: Fri May 24 18:54:52 2013
> New Revision: 250972
> URL: http://svnweb.freebsd.org/changeset/base/250972
>=20

> [...]

> @@ -977,7 +977,7 @@ spew_output(void)
>  #endif
>  	if (input_lines)
>  		copy_till(input_lines, true);	/* dump remainder of file */
> -	rv =3D ferror(ofp) =3D=3D 0 && fclose(ofp) =3D=3D 0;
> +	rv =3D ferror(ofp) =3D=3D 0 & fclose(ofp) =3D=3D 0;
>  	ofp =3D NULL;
>  	return rv;
>  }
>=20

This breaks head/.

=3D=3D=3D> usr.bin/patch (all)
cc  -O2 -pipe  -std=3Dgnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k
-W -Wno-unused-paramete
r -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
-Wcast-qual -Wwrite-str
ings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts
-Winline -Wnested-exter
ns -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c
/src/usr.bin/patch/backupfile.c
cc  -O2 -pipe  -std=3Dgnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k
-W -Wno-unused-paramete
r -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
-Wcast-qual -Wwrite-str
ings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts
-Winline -Wnested-exter
ns -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c
/src/usr.bin/patch/inp.c
cc  -O2 -pipe  -std=3Dgnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k
-W -Wno-unused-paramete
r -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
-Wcast-qual -Wwrite-str
ings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts
-Winline -Wnested-exter
ns -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c
/src/usr.bin/patch/mkpath.c
cc  -O2 -pipe  -std=3Dgnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k
-W -Wno-unused-paramete
r -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
-Wcast-qual -Wwrite-str
ings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts
-Winline -Wnested-exter
ns -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c
/src/usr.bin/patch/patch.c
cc1: warnings being treated as errors
/src/usr.bin/patch/patch.c: In function 'spew_output':
/src/usr.bin/patch/patch.c:980: warning: suggest parentheses around compari=
son in operand of &
*** Error code 1

Stop.
make: stopped in /src/usr.bin/patch
*** Error code 1

Stop.
make: stopped in /src/usr.bin
*** Error code 1


Glen


--FYef6pHvFBuPZp1D
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)

iQEcBAEBCAAGBQJRoEf/AAoJEFJPDDeguUajNvQIALnu9zMPNnLx0cBE8zb3kBiL
sZL0L/T35j6x8KwDgrVVDZrPdsMvQGAH3YRiOv4aWZr2n61qJWrQOWed2GmCmVmc
fgNTrhJQdFRmFq0fNuQCybgkoMKOXzOGe2tujR8hcrRVcpUQW2WrdpRGNDYal8oa
NHTNNg0+bKOOoV8fDhZkXlJMXJBWQylI5VwXcX/D482zR8LJacW6kUKu+ErxPmeN
oSmpaZDuUkjCWKp/BIRFIfe8CdbUy2cI5k1JDmWX8932wM0n8Qfl04qxSH78XsZx
HeVxJYqwCMkbKGW6/ntbmyYnjgN6qu3Oxsksctgcne2tawk5Av531p70ouE1w/0=
=0MlY
-----END PGP SIGNATURE-----

--FYef6pHvFBuPZp1D--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130525051127.GP1756>