From owner-freebsd-net@FreeBSD.ORG Tue Jan 27 19:36:28 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 636AB24E; Tue, 27 Jan 2015 19:36:28 +0000 (UTC) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0142.outbound.protection.outlook.com [157.56.111.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C2643B22; Tue, 27 Jan 2015 19:36:27 +0000 (UTC) Received: from CO2PR05MB764.namprd05.prod.outlook.com (10.141.227.19) by CO2PR05MB780.namprd05.prod.outlook.com (10.141.226.156) with Microsoft SMTP Server (TLS) id 15.1.65.19; Tue, 27 Jan 2015 19:36:20 +0000 Received: from CO2PR05MB761.namprd05.prod.outlook.com (10.141.227.13) by CO2PR05MB764.namprd05.prod.outlook.com (10.141.227.19) with Microsoft SMTP Server (TLS) id 15.1.65.19; Tue, 27 Jan 2015 19:36:17 +0000 Received: from CO2PR05MB761.namprd05.prod.outlook.com ([10.141.227.13]) by CO2PR05MB761.namprd05.prod.outlook.com ([10.141.227.13]) with mapi id 15.01.0065.013; Tue, 27 Jan 2015 19:36:17 +0000 From: Sreekanth Rupavatharam To: hiren panchasara Subject: Re: Double cleanup in igb_attach Thread-Topic: Double cleanup in igb_attach Thread-Index: AQHQOcQ8M6DG1/D37kKlfeofCj44QJzUW0EA//98HwA= Date: Tue, 27 Jan 2015 19:36:17 +0000 Message-ID: References: <20150127192814.GA63990@strugglingcoder.info> In-Reply-To: <20150127192814.GA63990@strugglingcoder.info> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.7.141117 x-originating-ip: [66.129.239.13] authentication-results: strugglingcoder.info; dkim=none (message not signed) header.d=none;strugglingcoder.info; dmarc=none action=none header.from=juniper.net; x-dmarcaction-test: None x-microsoft-antispam: BCL:0; PCL:0; RULEID:(3005004); SRVR:CO2PR05MB764; UriScan:; x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:;SRVR:CO2PR05MB764; x-forefront-prvs: 046985391D x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(51704005)(36756003)(122556002)(110136001)(46102003)(99286002)(54356999)(86362001)(66066001)(76176999)(50986999)(558084003)(77096005)(87936001)(40100003)(77156002)(83506001)(2900100001)(62966003)(2656002)(102836002)(2950100001)(106116001)(92566002); DIR:OUT; SFP:1102; SCL:1; SRVR:CO2PR05MB764; H:CO2PR05MB761.namprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2015 19:36:17.3426 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR05MB764 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:CO2PR05MB780; X-OriginatorOrg: juniper.net Cc: "jfv@freebsd.org" , "freebsd-net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 19:36:28 -0000 > >Seems reasonable to me at the first glance. > >We need to call IGB_CORE_LOCK_DESTROY(adapter) before returning though. > Not necessary. igb_detach does that.