Date: Wed, 1 Sep 2021 10:28:38 -0700 From: Craig Leres <leres@freebsd.org> To: Ian Lepore <ian@freebsd.org>, Warner Losh <imp@bsdimp.com> Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: Patched gpsd and /dev/pps0 results in "sleeping thread" kernel panic Message-ID: <24848efe-aee7-8fe2-9437-005a854a3525@freebsd.org> In-Reply-To: <5d812d36e5291af35ecadf910a6d5f76b60f1441.camel@freebsd.org> References: <dc4c4948-738e-c530-d96f-ade5cce5d3d2@freebsd.org> <CANCZdfos2NamQXXcjYyVAcJvUL21kQbjUR4KRTp1xXKsQN3SrA@mail.gmail.com> <5476ea21-9e8a-32f5-08ff-add46c02d910@freebsd.org> <CANCZdfoQTfWC4j=ArTdGQMwDDNsg-LMMYSrtF4BHtHZSuV%2BCkw@mail.gmail.com> <cd29114478b51ca577308dfaacd9df076813a313.camel@freebsd.org> <CANCZdfrkg9dKKoLqpEX285eYPspciNj2eeH8RVZEtAr9Nc1SBQ@mail.gmail.com> <CANCZdfrDsEotO36eE%2BUUvUxAWq=_3pQ9NivGU=_r=%2BikWdUQXw@mail.gmail.com> <5d812d36e5291af35ecadf910a6d5f76b60f1441.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------E2E1F9FA8C577A7C7CF5D5DB
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
On 9/1/21 8:07 AM, Ian Lepore wrote:
> Warner, I pointed out a small change needed to your proposed patch in
> D31763.
I was able to figure out what to change and am happy to report that it
solves the kernel panic; thanks! Now I'm back to only fighting with gpsd.
Are the other calls to pps_init() ok?
steel 183 # find . -name '*.c' | xargs fgrep -w pps_init
./dev/sio/sio.c: pps_init(&com->pps);
./i386/i386/elan-mmcr.c: pps_init(&elan_pps);
./kern/kern_tc.c:pps_init(struct pps_state *pps)
./kern/kern_tc.c: pps_init(pps);
I've attached my working version of the patch.
Craig
--------------E2E1F9FA8C577A7C7CF5D5DB
Content-Type: text/plain; charset=UTF-8;
name="patch2.txt"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="patch2.txt"
SW5kZXg6IGRldi9wcGJ1cy9wcGJfYmFzZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRldi9wcGJ1
cy9wcGJfYmFzZS5jCShyZXZpc2lvbiAxOCkKKysrIGRldi9wcGJ1cy9wcGJfYmFzZS5jCSh3
b3JraW5nIGNvcHkpCkBAIC0yMjAsNiArMjIwLDE0IEBACiAJbXR4X3VubG9jayhwcGItPnBw
Y19sb2NrKTsKIH0KIAorc3RydWN0IG10eCAqCitwcGJfZ2V0X2xvY2soZGV2aWNlX3QgYnVz
KQoreworCXN0cnVjdCBwcGJfZGF0YSAqcHBiID0gREVWVE9TT0ZUQyhidXMpOworCisJcmV0
dXJuIChwcGItPnBwY19sb2NrKTsKK30KKwogdm9pZAogX3BwYl9hc3NlcnRfbG9ja2VkKGRl
dmljZV90IGJ1cywgY29uc3QgY2hhciAqZmlsZSwgaW50IGxpbmUpCiB7CkluZGV4OiBkZXYv
cHBidXMvcHBiY29uZi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRldi9wcGJ1cy9wcGJjb25mLmgJ
KHJldmlzaW9uIDE4KQorKysgZGV2L3BwYnVzL3BwYmNvbmYuaAkod29ya2luZyBjb3B5KQpA
QCAtMjYxLDYgKzI2MSw3IEBACiAvKiBidXMgcmVsYXRlZCBmdW5jdGlvbnMgKi8KIGV4dGVy
biB2b2lkIHBwYl9sb2NrKGRldmljZV90KTsKIGV4dGVybiB2b2lkIHBwYl91bmxvY2soZGV2
aWNlX3QpOworZXh0ZXJuIHN0cnVjdCBtdHggKnBwYl9nZXRfbG9jayhkZXZpY2VfdCk7CiBl
eHRlcm4gdm9pZCBfcHBiX2Fzc2VydF9sb2NrZWQoZGV2aWNlX3QsIGNvbnN0IGNoYXIgKiwg
aW50KTsKIGV4dGVybiB2b2lkIHBwYl9pbml0X2NhbGxvdXQoZGV2aWNlX3QsIHN0cnVjdCBj
YWxsb3V0ICosIGludCk7CiBleHRlcm4gaW50IHBwYl9zbGVlcChkZXZpY2VfdCwgdm9pZCAq
LCBpbnQsIGNvbnN0IGNoYXIgKiwgaW50KTsKSW5kZXg6IGRldi9wcGJ1cy9wcHMuYwo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBkZXYvcHBidXMvcHBzLmMJKHJldmlzaW9uIDE4KQorKysgZGV2L3Bw
YnVzL3Bwcy5jCSh3b3JraW5nIGNvcHkpCkBAIC0xNDEsOSArMTQxLDExIEBACiAJICAgIFVJ
RF9ST09ULCBHSURfV0hFRUwsIDA2MDAsIFBQU19OQU1FICIlZCIsIHVuaXQpOwogCXNjLT5k
ZXZzWzBdID0gZDsKIAlzYy0+cHBzWzBdLnBwc2NhcCA9IFBQU19DQVBUVVJFQVNTRVJUIHwg
UFBTX0VDSE9BU1NFUlQ7CisJc2MtPnBwc1swXS5kcml2ZXJfYWJpID0gUFBTX0FCSV9WRVJT
SU9OOworCXNjLT5wcHNbMF0uZHJpdmVyX210eCA9IHBwYl9nZXRfbG9jayhwcGJ1cyk7CiAJ
ZC0+c2lfZHJ2MSA9IHNjOwogCWQtPnNpX2RydjIgPSAodm9pZCopMDsKLQlwcHNfaW5pdCgm
c2MtPnBwc1swXSk7CisJcHBzX2luaXRfYWJpKCZzYy0+cHBzWzBdKTsKIAogCXBwYl9sb2Nr
KHBwYnVzKTsKIAlpZiAocHBiX3JlcXVlc3RfYnVzKHBwYnVzLCBkZXYsIFBQQl9ET05UV0FJ
VCkpIHsKQEAgLTE5Myw5ICsxOTUsMTEgQEAKIAkJCSAgVUlEX1JPT1QsIEdJRF9XSEVFTCwg
MDYwMCwgUFBTX05BTUUgIiVkYiVkIiwgdW5pdCwgaSAtIDEpOwogCQkJc2MtPmRldnNbaV0g
PSBkOwogCQkJc2MtPnBwc1tpXS5wcHNjYXAgPSBQUFNfQ0FQVFVSRUFTU0VSVCB8IFBQU19D
QVBUVVJFQ0xFQVI7CisJCQlzYy0+cHBzW2ldLmRyaXZlcl9hYmkgPSBQUFNfQUJJX1ZFUlNJ
T047CisJCQlzYy0+cHBzW2ldLmRyaXZlcl9tdHggPSBwcGJfZ2V0X2xvY2socHBidXMpOwog
CQkJZC0+c2lfZHJ2MSA9IHNjOwogCQkJZC0+c2lfZHJ2MiA9ICh2b2lkICopKGludHB0cl90
KWk7Ci0JCQlwcHNfaW5pdCgmc2MtPnBwc1tpXSk7CisJCQlwcHNfaW5pdF9hYmkoJnNjLT5w
cHNbaV0pOwogCQl9CiAJCXBwYl9sb2NrKHBwYnVzKTsKIAl9IHdoaWxlICgwKTsK
--------------E2E1F9FA8C577A7C7CF5D5DB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?24848efe-aee7-8fe2-9437-005a854a3525>