From owner-cvs-all Fri Dec 22 13:30:19 2000 From owner-cvs-all@FreeBSD.ORG Fri Dec 22 13:30:16 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 700D537B400; Fri, 22 Dec 2000 13:30:16 -0800 (PST) Received: (from iedowse@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id eBMLUG743954; Fri, 22 Dec 2000 13:30:16 -0800 (PST) (envelope-from iedowse) Message-Id: <200012222130.eBMLUG743954@freefall.freebsd.org> From: Ian Dowse Date: Fri, 22 Dec 2000 13:30:16 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/usr.sbin/rwhod rwhod.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG iedowse 2000/12/22 13:30:16 PST Modified files: usr.sbin/rwhod rwhod.c Log: Ensure that received packets are at least as long as the rwho packet header before trying to process them. Without this sanity check, rwhod can attempt to byte-swap all of memory when a short packet is received, and so dies with a SIGBUS. While I'm here, change two other syslog messages to be more informative: use dotted quad rather than hex notation for IP addresses, and include the source IP in the 'bad from port' message. PR: bin/14844 Reviewed by: dwmalone Revision Changes Path 1.15 +11 -5 src/usr.sbin/rwhod/rwhod.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message