Date: Wed, 09 Aug 2023 13:37:48 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 272312] [NEW PORT] security/p5-openxpki-clca: Toolkit for root CA Message-ID: <bug-272312-7788-kpILnOB6Dq@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-272312-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-272312-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272312 Robert Clausecker <fuz@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org Status|New |Open --- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> --- Thank you for your submission. Contrary to what I said in my email, this submission is not ready to be committed. Some issues for you to check: - You seem to be doing a bunch of rote replacements in an unconventional w= ay. Check if you can use USES=3Dshebangfix instead - if not, I recommend writing a patch file that replaces all instances of = the token you want to replace with some easy to see token. Then use REINPLACE_CMD to fix all instances of this token. For example, replace openssl with %%OPENSSL%% in a patch file, then ${REINPLACE_CMD} -e s,%%OPENSSL%%,${something} to fix this up. This simplifies the whole th= ing to ${FIND} ${some_dir} -exec ${REINPLACE_CMD} -e ... {} + - I recommend moving ${REINPLACE_CMD} use to pre-configure as to not break make makepatch - in any way, do not delete the .bak files as these are used by stage-qa to check for misuse of REINPLACE_CMD - use ${PERL} instead of hardcoding ${PREFIX}/bin/perl - do not assume the port directory is writable. Put temporarily files like filelist into ${WRKDIR} - your pkg-plist does not install anything unless EXAMPLES are selected. Is this correct? - do not define dummy do-build or do-install targets. If you don't need t= hese targets, define NO_BUILD=3Dyes or NO_INSTALL=3Dyes as appropriate. - your installation message recommends that the user copies all these file= s to his or her home directory. Why is this needed? Can't you install the scripts and files into standard locations so they can be used from where they ar= e? We want ports to be usable as they are. Ports are not just a vehicle to download a bunch of files to the users computer. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-272312-7788-kpILnOB6Dq>