From owner-freebsd-hackers@FreeBSD.ORG Wed Dec 3 03:30:24 2003 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0814116A4CE for ; Wed, 3 Dec 2003 03:30:24 -0800 (PST) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DE0943FBF for ; Wed, 3 Dec 2003 03:30:06 -0800 (PST) (envelope-from sos@spider.deepcore.dk) Received: from spider.deepcore.dk (localhost [127.0.0.1]) by spider.deepcore.dk (8.12.10/8.12.10) with ESMTP id hB3BUgtx058498; Wed, 3 Dec 2003 12:30:42 +0100 (CET) (envelope-from sos@spider.deepcore.dk) Received: (from sos@localhost) by spider.deepcore.dk (8.12.10/8.12.10/Submit) id hB3BUgmb058497; Wed, 3 Dec 2003 12:30:42 +0100 (CET) (envelope-from sos) From: Soren Schmidt Message-Id: <200312031130.hB3BUgmb058497@spider.deepcore.dk> In-Reply-To: <013d01c3b924$8b87cd40$43c8a8c0@orac> To: Duncan Barclay Date: Wed, 3 Dec 2003 12:30:42 +0100 (CET) X-Mailer: ELM [version 2.4ME+ PL99f (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1 X-mail-scanned: by DeepCore Virus & Spam killer v1.3 cc: freebsd-hackers@FreeBSD.ORG Subject: Re: sata on -stable X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Dec 2003 11:30:24 -0000 It seems Duncan Barclay wrote: I had a spare minute earlier today, this should do the trick (and is part of a larger patch due soon), please test and let me know... Index: ata-dma.c =================================================================== RCS file: /home/ncvs/src/sys/dev/ata/ata-dma.c,v retrieving revision 1.35.2.35 diff -u -r1.35.2.35 ata-dma.c --- ata-dma.c 26 Oct 2003 18:34:23 -0000 1.35.2.35 +++ ata-dma.c 3 Dec 2003 10:28:07 -0000 @@ -506,6 +506,22 @@ } break; + case 0x31491106: /* VIA 8237 SATA part */ + if (udmamode) { + error = ata_command(atadev, ATA_C_SETFEATURES, 0, + ATA_UDMA + udmamode, + ATA_C_F_SETXFER, ATA_WAIT_READY); + if (bootverbose) + ata_prtdev(atadev, "%s setting UDMA%d on VIA chip\n", + (error) ? "failed" : "success", udmamode); + if (!error) { + ata_dmacreate(atadev, apiomode, ATA_UDMA + udmamode); + return; + } + } + /* we could set PIO mode timings, but we assume the BIOS did that */ + break; + case 0x01bc10de: /* nVIDIA nForce */ case 0x74411022: /* AMD 768 */ case 0x74111022: /* AMD 766 */ @@ -522,7 +538,8 @@ char *chip = "VIA"; if (ata_find_dev(parent, 0x31471106, 0) || /* 8233a */ - ata_find_dev(parent, 0x31771106, 0)) { /* 8235 */ + ata_find_dev(parent, 0x31771106, 0) || /* 8235 */ + ata_find_dev(parent, 0x31491106, 0)) { /* 8237 */ udmamode = imin(udmamode, 6); reg_val = via_modes[3]; } Index: ata-pci.c =================================================================== RCS file: /home/ncvs/src/sys/dev/ata/ata-pci.c,v retrieving revision 1.32.2.17 diff -u -r1.32.2.17 ata-pci.c --- ata-pci.c 22 Oct 2003 14:43:52 -0000 1.32.2.17 +++ ata-pci.c 3 Dec 2003 10:28:07 -0000 @@ -189,7 +189,12 @@ return "VIA 8233 ATA133 controller"; if (ata_find_dev(dev, 0x31771106, 0)) return "VIA 8235 ATA133 controller"; + if (ata_find_dev(dev, 0x31491106, 0)) + return "VIA 8237 ATA133 controller"; return "VIA Apollo ATA controller"; + + case 0x31491106: + return "VIA 8237 SATA150 controller"; case 0x55131039: if (ata_find_dev(dev, 0x06301039, 0x30) || -Søren .. but it works under windows!!