From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 28 12:50:03 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2A771901 for ; Wed, 28 Aug 2013 12:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0AB8124FC for ; Wed, 28 Aug 2013 12:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r7SCo2ha097558 for ; Wed, 28 Aug 2013 12:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r7SCo2SZ097557; Wed, 28 Aug 2013 12:50:02 GMT (envelope-from gnats) Resent-Date: Wed, 28 Aug 2013 12:50:02 GMT Resent-Message-Id: <201308281250.r7SCo2SZ097557@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Boris Samorodov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4D8AA66A for ; Wed, 28 Aug 2013 12:43:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3B8D3248C for ; Wed, 28 Aug 2013 12:43:30 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r7SChUtE065156 for ; Wed, 28 Aug 2013 12:43:30 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r7SChU0J065149; Wed, 28 Aug 2013 12:43:30 GMT (envelope-from nobody) Message-Id: <201308281243.r7SChU0J065149@oldred.freebsd.org> Date: Wed, 28 Aug 2013 12:43:30 GMT From: Boris Samorodov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/181617: [patch] misc/window: fix build with clang, add LICENSE and more X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Aug 2013 12:50:03 -0000 >Number: 181617 >Category: ports >Synopsis: [patch] misc/window: fix build with clang, add LICENSE and more >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Aug 28 12:50:02 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Boris Samorodov >Release: FreeBSD 10.0-CURRENT >Organization: BSDprint >Environment: FreeBSD bsam.int.wart.ru 10.0-CURRENT FreeBSD 10.0-CURRENT #36 r254961: Wed Aug 28 02:04:00 SAMT 2013 bsam@bsam.int.wart.ru:/usr/obj/usr/src/sys/BB64X amd64 >Description: The ports fails to build with clang: ----- cmd.c:297:3: error: non-void function 'setselwin' should return a value [-Wreturn-type] return; ^ ----- >How-To-Repeat: >Fix: . fix build with clang (CFLAGS+=-Wno-return-type); . trim Makefile headers; . reword COMMENT; . add LICENSE (BSD); . remove check for unsupported FreeBSD versions (<800093). Patch attached with submission follows: Index: Makefile =================================================================== --- Makefile (revision 325431) +++ Makefile (working copy) @@ -1,9 +1,5 @@ -# New ports collection makefile for: window -# Date created: 31 May 2009 -# Whom: Tom Rhodes -# +# Created by: Tom Rhodes # $FreeBSD$ -# PORTNAME= window PORTVERSION= 1.0 @@ -11,15 +7,12 @@ MASTER_SITES= http://people.FreeBSD.org/~trhodes/ MAINTAINER= trhodes@FreeBSD.org -COMMENT= The FreeBSD usr.bin/window application +COMMENT= Window environment on ASCII terminals -.include +LICENSE= BSD -.if ${OSVERSION} < 800093 -IGNORE= window-1.0 is still part of the base system -.endif - WRKSRC= ${WRKDIR}/window +CFLAGS+= -Wno-return-type MAN1= window.1 PLIST_FILES= bin/window @@ -28,4 +21,4 @@ ${INSTALL_PROGRAM} ${WRKSRC}/window ${PREFIX}/bin ${INSTALL_DATA} ${WRKSRC}/${MAN1} ${PREFIX}/man/man1 -.include +.include >Release-Note: >Audit-Trail: >Unformatted: