From owner-freebsd-net@FreeBSD.ORG  Mon Jun 14 22:48:55 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EB97F1065672;
	Mon, 14 Jun 2010 22:48:55 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from out-0.mx.aerioconnect.net (out-0-7.mx.aerioconnect.net
	[216.240.47.67])
	by mx1.freebsd.org (Postfix) with ESMTP id C6FFB8FC13;
	Mon, 14 Jun 2010 22:48:55 +0000 (UTC)
Received: from idiom.com (postfix@mx0.idiom.com [216.240.32.160])
	by out-0.mx.aerioconnect.net (8.13.8/8.13.8) with ESMTP id
	o5EMms6C002389; Mon, 14 Jun 2010 15:48:54 -0700
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org
	(h-67-100-89-137.snfccasy.static.covad.net [67.100.89.137])
	by idiom.com (Postfix) with ESMTP id 306512D6012;
	Mon, 14 Jun 2010 15:48:52 -0700 (PDT)
Message-ID: <4C16B1ED.7000204@elischer.org>
Date: Mon, 14 Jun 2010 15:49:17 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US;
	rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4
MIME-Version: 1.0
To: Luigi Rizzo <rizzo@iet.unipi.it>
References: <AANLkTina6_2EoZOVPWD3pPcJ4FbeDi8eahcHXp-KL-XN@mail.gmail.com>
	<20100614222227.GA98913@onelab2.iet.unipi.it>
In-Reply-To: <20100614222227.GA98913@onelab2.iet.unipi.it>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.67 on 216.240.47.51
Cc: Ermal Lu?i <eri@freebsd.org>, freebsd-net <freebsd-net@freebsd.org>,
	Luigi Rizzo <luigi@freebsd.org>
Subject: Re: [PATCH] ipfw pipe bandwidth parameter parser.
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jun 2010 22:48:56 -0000

On 6/14/10 3:22 PM, Luigi Rizzo wrote:
> On Mon, Jun 14, 2010 at 11:01:43PM +0100, Ermal Lu?i wrote:
>> Hello,
>>
>> on FreeBSD-STABLE at least ipfw wrongly interprets dummynet
>> configurations of the type:
>>
>> pipe 10 config bw 1.5Mb
>>                             ^^^
>
> Given that there is an easy workaround (use bw 1500Kbit/s)
> i'd probably just leave it alone, at least for 8.1
>
> I think this behaviour (only accepting integers before the unit)
> has been there forever, and is one of the many things broken in
> the code that parses bandwidth, sizes and delays.
> I am slightly afraid of fixing it because people might have
> (broken) configurations relying on undocumented behaviour.


the answer may be to just doccument it properly.
then it is DOCUMENTED behaviour.
>
> cheers
> luigi
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"