Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Jun 2012 04:24:13 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r237046 - head/sys/dev/ath
Message-ID:  <201206140424.q5E4ODMB069324@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adrian
Date: Thu Jun 14 04:24:13 2012
New Revision: 237046
URL: http://svn.freebsd.org/changeset/base/237046

Log:
  Shrink ath_buf a little more:
  
  * Resize some types.  In particular, bfs_seqno can be uint16_t for now.
    Previous work would assign the unassigned seqno a value of -1, which
    I obviously can't do here.
  
  * Remove bfs_pktdur.  It was in the original code but nothing so far uses
    it.
  
  This gets ath_buf down (on my i386 system) to 292 bytes from 300 bytes.
  I'd rather it be much, much smaller.

Modified:
  head/sys/dev/ath/if_athvar.h

Modified: head/sys/dev/ath/if_athvar.h
==============================================================================
--- head/sys/dev/ath/if_athvar.h	Thu Jun 14 04:18:56 2012	(r237045)
+++ head/sys/dev/ath/if_athvar.h	Thu Jun 14 04:24:13 2012	(r237046)
@@ -211,15 +211,16 @@ struct ath_buf {
 
 	/* This state is kept to support software retries and aggregation */
 	struct {
-		int bfs_seqno;		/* sequence number of this packet */
-		int bfs_retries;	/* retry count */
-		uint16_t bfs_tid;	/* packet TID (or TID_MAX for no QoS) */
-		uint16_t bfs_pri;	/* packet AC priority */
-		struct ath_txq *bfs_txq;	/* eventual dest hardware TXQ */
-		uint16_t bfs_pktdur;	/* packet duration (at current rate?) */
-		uint16_t bfs_nframes;	/* number of frames in aggregate */
+		uint16_t bfs_seqno;	/* sequence number of this packet */
 		uint16_t bfs_ndelim;	/* number of delims for padding */
 
+		uint8_t bfs_retries;	/* retry count */
+		uint8_t bfs_tid;	/* packet TID (or TID_MAX for no QoS) */
+		uint8_t bfs_nframes;	/* number of frames in aggregate */
+		uint8_t bfs_pri;	/* packet AC priority */
+
+		struct ath_txq *bfs_txq;	/* eventual dest hardware TXQ */
+
 		u_int32_t bfs_aggr:1,		/* part of aggregate? */
 		    bfs_aggrburst:1,	/* part of aggregate burst? */
 		    bfs_isretried:1,	/* retried frame? */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206140424.q5E4ODMB069324>