From owner-svn-src-all@freebsd.org Wed Mar 20 22:10:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BC6A0153A504; Wed, 20 Mar 2019 22:10:12 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3DDD2839C3; Wed, 20 Mar 2019 22:10:12 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f53.google.com with SMTP id y18so3137803lfe.1; Wed, 20 Mar 2019 15:10:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oqEsjvja6F5KVOpYP+FAderVBjpA9DK/VNngrQUFtZk=; b=eHCqae3KFFMYs7sJ0M9g3DPAEb50/hTVAAe+H9i5NgnAIdx2RiOzvwcphoqOMNJRc0 eIeIVmn7QxdlOk1iTv1amnvLzb2T4j9C2to6MfZtn+mtvVsC1KAye/Tklck8fhpmg1c3 2yOvtvLETbTz3GKcwWxp1I4iyFkvXojkrJvuN9p3DY92oQ2g65VqE/6vpsIx4AZvR1hJ FqBadxD0BzqtsC0/azEjyXgLTI4NMzVxlEfwgbbyjEQYbdWiqdoeLC44a6D7LObRDxl1 NHb0mYjGCAXnyiolipuIVc785dpKMSFZP5Hc5NFzw7nebZKp881FDa+jy4sgY7nMfdEg X6Lg== X-Gm-Message-State: APjAAAU8/jEP45o7Rvdk3f1vvr0FBpw1IqStD6UGNIQ9a0gqFavPV16Q 4DUL8Hr1jDynNcZnWBdLduKznTtN+7BXfVCtSoymp2Xh X-Google-Smtp-Source: APXvYqyv9rEA/q7rDHM469eAR9S915aWtU6847Z3fQUbKv2oX2j4uE+oKOrxm1Ckd6aPrZm3al7ox/yDIK9O1zCFXn0= X-Received: by 2002:ac2:424c:: with SMTP id m12mr103654lfl.62.1553119810094; Wed, 20 Mar 2019 15:10:10 -0700 (PDT) MIME-Version: 1.0 References: <201903202148.x2KLmiJr059285@repo.freebsd.org> <201903202201.x2KM1Flm057608@gndrsh.dnsmgr.net> In-Reply-To: <201903202201.x2KM1Flm057608@gndrsh.dnsmgr.net> From: Alan Somers Date: Wed, 20 Mar 2019 16:09:58 -0600 Message-ID: Subject: Re: svn commit: r345350 - in head: . lib/libjail sbin/mount_fusefs sys/conf sys/fs/fuse sys/modules sys/modules/fuse sys/modules/fusefs To: rgrimes@freebsd.org Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3DDD2839C3 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.93)[-0.926,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 22:10:12 -0000 On Wed, Mar 20, 2019 at 4:01 PM Rodney W. Grimes wrote: > > > Author: asomers > > Date: Wed Mar 20 21:48:43 2019 > > New Revision: 345350 > > URL: https://svnweb.freebsd.org/changeset/base/345350 > > > > Log: > > Rename fuse(4) to fusefs(4) > > > > This makes it more consistent with other filesystems, which all end in "fs", > > and more consistent with its mount helper, which is already named > > "mount_fusefs". > > > > Reviewed by: cem, rgrimes > > I did not review this code, I made a single comment that > it should be discussed on an applicable mail list (arch@) > which you did do, and I thank you for that. > > I would of eventually objected to the "do not rename the source", > as that is one of the sighted reasons we use svn, is it is near > costless to do moves, and this just trades one missmatch for > another, which in my book is a near nop. > > Reviews are still not being allowed enough world rotates > before committing. I am presently abroad, with poor net, > and busy. Sorry, I didn't realize you weren't done. But the other great thing about SVN is that we can do stuff, and then do more stuff. Would you like for me to rename the source files as well? I could do that. The one thing that I won't agree to do is to rename fuse_kernel.h => fusefs_kernel.h, because that file comes verbatim from upstream and we should keep the original name to make it easy to find(1). -Alan