From owner-svn-src-head@freebsd.org  Thu Aug  9 18:09:45 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49F0C106EB34
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Thu,  9 Aug 2018 18:09:45 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org
 [54.200.247.200])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CC54C8114F
 for <svn-src-head@freebsd.org>; Thu,  9 Aug 2018 18:09:44 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-RoutePath: aGlwcGll
X-MHO-User: 62ed1730-9bff-11e8-93fa-f3ebd9db2b94
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 67.177.211.60
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [67.177.211.60])
 by outbound1.ore.mailhop.org (Halon) with ESMTPSA
 id 62ed1730-9bff-11e8-93fa-f3ebd9db2b94;
 Thu, 09 Aug 2018 18:09:42 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id w79I9fbf059308;
 Thu, 9 Aug 2018 12:09:41 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1533838181.9860.119.camel@freebsd.org>
Subject: Re: svn commit: r337546 - head/sys/kern
From: Ian Lepore <ian@freebsd.org>
To: Kyle Evans <kevans@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Date: Thu, 09 Aug 2018 12:09:41 -0600
In-Reply-To: <201808091753.w79HrJsY076268@repo.freebsd.org>
References: <201808091753.w79HrJsY076268@repo.freebsd.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Aug 2018 18:09:45 -0000

On Thu, 2018-08-09 at 17:53 +0000, Kyle Evans wrote:
> Author: kevans
> Date: Thu Aug  9 17:53:18 2018
> New Revision: 337546
> URL: https://svnweb.freebsd.org/changeset/base/337546
> 
> Log:
>   subr_prf: Use "sizeof current_boot_tag" instead
> 
> Modified:
>   head/sys/kern/subr_prf.c
> 
> Modified: head/sys/kern/subr_prf.c
> =====================================================================
> =========
> --- head/sys/kern/subr_prf.c	Thu Aug  9 17:47:47 2018	(
> r337545)
> +++ head/sys/kern/subr_prf.c	Thu Aug  9 17:53:18 2018	(
> r337546)
> @@ -1040,7 +1040,7 @@ msgbufinit(void *ptr, int size)
>  	/* Attempt to fetch kern.boot_tag tunable on first mapping
> */
>  	if (!msgbufmapped)
>  		TUNABLE_STR_FETCH("kern.boot_tag", current_boot_tag,
> -		    BOOT_TAG_SZ + 1);
> +		    sizeof current_boot_tag);

Style(9) mandates parens with sizeof.

-- Ian

>  	msgbufp = (struct msgbuf *)(cp + size);
>  	msgbuf_reinit(msgbufp, cp, size);
>  	msgbuf_addstr(msgbufp, -1, current_boot_tag, 0);
>