Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Oct 2020 02:19:33 +0000 (UTC)
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r366744 - head/sys/kern
Message-ID:  <202010160219.09G2JXuD035621@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mjg
Date: Fri Oct 16 02:19:33 2020
New Revision: 366744
URL: https://svnweb.freebsd.org/changeset/base/366744

Log:
  cache: flip inverted condition in previous
  
  It happened to not affect correctness in that the fallback code would
  simply neglect to promote the entry.

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==============================================================================
--- head/sys/kern/vfs_cache.c	Fri Oct 16 00:56:13 2020	(r366743)
+++ head/sys/kern/vfs_cache.c	Fri Oct 16 02:19:33 2020	(r366744)
@@ -1624,7 +1624,7 @@ negative_success:
 		vfs_smr_exit();
 		goto out_fallback;
 	}
-	if (neg_hot) {
+	if (!neg_hot) {
 		vfs_smr_exit();
 		if (!cache_negative_promote_cond(dvp, cnp, ncp, hash))
 			goto out_fallback;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202010160219.09G2JXuD035621>