From owner-freebsd-rc@FreeBSD.ORG  Fri Jun  9 21:26:10 2006
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
X-Original-To: freebsd-rc@FreeBSD.org
Delivered-To: freebsd-rc@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D220316A474
	for <freebsd-rc@FreeBSD.org>; Fri,  9 Jun 2006 21:26:10 +0000 (UTC)
	(envelope-from erdgeist@erdgeist.org)
Received: from elektropost.org (elektropost.org [80.237.196.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A660F43D78
	for <freebsd-rc@FreeBSD.org>; Fri,  9 Jun 2006 21:26:07 +0000 (GMT)
	(envelope-from erdgeist@erdgeist.org)
Received: (qmail 91506 invoked by uid 0); 9 Jun 2006 21:25:58 -0000
Received: from erdgeist.org (erdgeist@erdgeist.org@80.237.196.15)
	by elektropost.org with AES256-SHA encrypted SMTP;
	9 Jun 2006 21:25:58 -0000
Date: Fri, 9 Jun 2006 23:25:58 +0200 (CEST)
From: Dirk Engling <erdgeist@erdgeist.org>
To: Xin LI <delphij@FreeBSD.org>
In-Reply-To: <200606091826.k59IQfmo057494@freefall.freebsd.org>
Message-ID: <20060609222512.Y15476@erdgeist.org>
References: <200606091826.k59IQfmo057494@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org
Subject: Re: conf/95162: [patch] Missing feature in rc.subr
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jun 2006 21:26:10 -0000

On Fri, 9 Jun 2006, Xin LI wrote:

> Synopsis: [patch] Missing feature in rc.subr
>
> Responsible-Changed-From-To: freebsd-bugs->freebsd-rc
> Responsible-Changed-By: delphij
> Responsible-Changed-When: Fri Jun 9 18:26:02 UTC 2006
> Responsible-Changed-Why:
> Over to the rc mailing list.  Patch looks fine to me, may I commit
> it?
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=95162

Very nice idea. However, it does not take care of rc_conf_files, which 
means that a variable set in /etc/rc.conf.local can not be unset that way.

Further to be _very_  sure I'd

grep -v "^${rcvar}="

to avoid removing too much from rc.conf.

Also for clarity one could remove all ^${rcvar}= entries when enabling 
${rcvar}, possibly in an extra clear function, which might also take care
of rc_conf_files.

Have I missed anything else? I would like to see this feature when its 
ready.

Regards

   erdgeist