From owner-svn-src-all@freebsd.org Thu Jul 11 04:48:43 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B57F615EC182 for ; Thu, 11 Jul 2019 04:48:43 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 42D458B8AD for ; Thu, 11 Jul 2019 04:48:43 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-vs1-xe43.google.com with SMTP id h28so3044770vsl.12 for ; Wed, 10 Jul 2019 21:48:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=DsJqhKklihTqGHjZRjvsZMbn6SVYL6vj8sP7JCbsRb8=; b=MyX7Dmczl08ivld2hdylDWYRbsKKGNyGWJkefq9p+RPmdwmC4Pb9QNG1MRszcZOzxS 5SAkfcaOLSjff0G82UyhpDfBdLmiEA/D8zj5fucDcwkAO6S9dAtI9eyTA5KN9rdA2SGo NyRveBri1LCXdKxrjb6qvlbo/1Uy1xNw6/XI0DOFbkYRFJYVFlCRsC2IaussO6NldgeD wlIXysVoEMFGYLF6dSVwnCtIBmoUFDx5kN8E2n4RNRnCeQfabYYTGVm0fd4X0payPiuJ Bhg05gPTMOs3HpECxviA0enYYl7/m7UhZeWfwD0aETr0BVXmEN4gNo6Ms9ERDQtzibPW Wd6A== X-Gm-Message-State: APjAAAXSBwTHo5LXk2MnQbz37MjHOS2TRPXLgz5cX/MW1TO/dodSWGvi MZ194MpnfaLnKNo0Itom8amJsQ== X-Google-Smtp-Source: APXvYqzSrgPMrmoWZpLGhZTl7L9fLdPBP29faGVRCk/+HjlGDVe58EKmrse4RdYrqF1HdbZJa2WCwg== X-Received: by 2002:a67:f116:: with SMTP id n22mr1149424vsk.73.1562820521300; Wed, 10 Jul 2019 21:48:41 -0700 (PDT) Received: from ?IPv6:2607:fb10:7061:7fd::15b5? ([2607:fb10:7061:7fd::15b5]) by smtp.gmail.com with ESMTPSA id i137sm1888993vkd.24.2019.07.10.21.48.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jul 2019 21:48:40 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r349893 - in head/sys: modules/tcp/rack netinet netinet/tcp_stacks sys From: Randall Stewart In-Reply-To: <4cdc824e-7e71-731d-50d4-c3f6231f9858@FreeBSD.org> Date: Thu, 11 Jul 2019 00:48:38 -0400 Cc: Randall Ray Stewart , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <7695E2FC-406D-46CE-88F2-0690B9AAA36D@netflix.com> References: <201907102040.x6AKeern006731@repo.freebsd.org> <4cdc824e-7e71-731d-50d4-c3f6231f9858@FreeBSD.org> To: John Baldwin X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 42D458B8AD X-Spamd-Bar: ------ X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.952,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2019 04:48:44 -0000 John: Thanks for the suggestions.. I have committed changes to the two nits. As to M_PROTO1, I see that in the NF world we have removed M_PROTO12 and moved the M_PROTO=E2=80=99s up 1 i.e. M_PROTO1 =3D=3D = 0x2000 So for now it is safe, since the M_TSTMP_LRO is not yet used.. but in my up and coming commits I will have to address this i.e. either do the same thing or just make it use M_PROTO12. There are a couple of places M_PROTO1 is used on the receive path so that would not work there :o After I get the DSACK fixes in my next change to get BBR in will be the LRO work=E2=80=A6 So maybe I should just settle on using M_PROTO12 for that=20 what do you think? R > On Jul 10, 2019, at 7:28 PM, John Baldwin wrote: >=20 > On 7/10/19 1:40 PM, Randall Stewart wrote: >> Author: rrs >> Date: Wed Jul 10 20:40:39 2019 >> New Revision: 349893 >> URL: https://svnweb.freebsd.org/changeset/base/349893 >>=20 >> Log: >> This commit updates rack to what is basically being used at NF as >> well as sets in some of the groundwork for committing BBR. The >> hpts system is updated as well as some other needed utilities >> for the entrance of BBR. This is actually part 1 of 3 more >> needed commits which will finally complete with BBRv1 being >> added as a new tcp stack. >>=20 >> Sponsored by: Netflix Inc. >> Differential Revision: https://reviews.freebsd.org/D20834 >=20 > Is it safe for M_TSTMP_LRO to conflict with M_PROTO1? >=20 > Also, it seems you changed the copyright range on rack.c from > 2016-2019 to just 2016 which I suspect is an accident. >=20 > I would suggest using #error here: >=20 > #ifndef TCPHPTS > fatal error missing option TCPHSTS in the build; > #endif >=20 > --=20 > John Baldwin ------ Randall Stewart rrs@netflix.com