From owner-freebsd-current  Fri Feb  8 17:40:46 2002
Delivered-To: freebsd-current@freebsd.org
Received: from rwcrmhc54.attbi.com (rwcrmhc54.attbi.com [216.148.227.87])
	by hub.freebsd.org (Postfix) with ESMTP id C4B6437B421
	for <current@FreeBSD.ORG>; Fri,  8 Feb 2002 17:40:33 -0800 (PST)
Received: from InterJet.elischer.org ([12.232.206.8])
          by rwcrmhc54.attbi.com
          (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP
          id <20020209014033.QKTM1214.rwcrmhc54.attbi.com@InterJet.elischer.org>;
          Sat, 9 Feb 2002 01:40:33 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id RAA04520;
	Fri, 8 Feb 2002 17:40:04 -0800 (PST)
Date: Fri, 8 Feb 2002 17:40:01 -0800 (PST)
From: Julian Elischer <julian@elischer.org>
To: Tor.Egge@cvsup.no.freebsd.org
Cc: gene@nttmcl.com, david@catwhisker.org, current@FreeBSD.ORG
Subject: Re: Hang on flushing buffers w/today's -CURRENT, SMP system
In-Reply-To: <20020209012620H.tegge@cvsup.no.freebsd.org>
Message-ID: <Pine.BSF.4.21.0202081738230.4147-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

yes,, this exactly fits the symptoms!

I've committed it.
(it's definitly wrong)
assume this will solv ethe problem.
now why doesn't MINE fail?

On Sat, 9 Feb 2002 Tor.Egge@cvsup.no.freebsd.org wrote:

> > hmmmm  so what is the difference between your kernel and mine that works?
> > 
> > just out of curiosity, have you tried a very latest -current? 
> > do you have your own config? how does GENERIC behave?
> > (what kind of disks do you have?)
> 
> It looks like a call to setrunqueue() was incorrectly dropped in 
> the latest version of kern_shutdown.c.
> 
> Index: kern_shutdown.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/kern/kern_shutdown.c,v
> retrieving revision 1.118
> diff -u -r1.118 kern_shutdown.c
> --- kern_shutdown.c	7 Feb 2002 20:58:44 -0000	1.118
> +++ kern_shutdown.c	9 Feb 2002 01:11:18 -0000
> @@ -272,6 +272,7 @@
>  				DROP_GIANT();
>     				for (subiter = 0; subiter < 50 * iter; subiter++) {
>       					mtx_lock_spin(&sched_lock);
> +     					setrunqueue(curthread);
>  					curthread->td_proc->p_stats->p_ru.ru_nvcsw++;
>       					mi_switch(); /* Allow interrupt threads to run */
>       					mtx_unlock_spin(&sched_lock);
> 
> 
> - Tor Egge
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message