From owner-freebsd-net Tue Jun 19 15:48:17 2001 Delivered-To: freebsd-net@freebsd.org Received: from silby.com (cb34181-a.mdsn1.wi.home.com [24.14.173.39]) by hub.freebsd.org (Postfix) with ESMTP id 52F9D37B401 for ; Tue, 19 Jun 2001 15:48:15 -0700 (PDT) (envelope-from silby@silby.com) Received: (qmail 54949 invoked by uid 1000); 19 Jun 2001 22:48:14 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 19 Jun 2001 22:48:14 -0000 Date: Tue, 19 Jun 2001 17:48:14 -0500 (CDT) From: Mike Silbersack To: Bosko Milekic Cc: , Jesper Skriver Subject: Re: tcp template removal / scalability patch In-Reply-To: <20010619173424.A8399@technokratis.com> Message-ID: <20010619173956.H52501-100000@achilles.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Tue, 19 Jun 2001, Bosko Milekic wrote: > > I've attached two patches; one for current, and one for stable. Please > > review / test, _especially_ if you're using IPv6 or IPSec - while those > > cases look correct, I'm not running either and haven't tested them. > > I've spotted some patch-related (not conceptual) things worth > mentionning, so I'll do that now and give you the conceptual review a little > later, hopefully before I leave. Ok, I'll go through and check out all the spacing issues you raised. This would be easier if jesper MFCs the removal of TCP_COMPAT_42, which causes the differences between -stable and -current. :) Looking back, I should change the keepalive case so that it never needs the tcp template; this will require simple mods to tcp_respond. I'll change this and make a new patch soon. > Perhaps this should be an INVARIANTS-enabled KASSERT()? Is this > something that can only happen due to programming error? It seems to me like > it's the case here (assuming we're not dealing with a huge-assed memory > corruption). Actually, I should just change t_template to unused and avoid the issue altogether. You're right, only a programming error would fill that field now. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message