From owner-cvs-src@FreeBSD.ORG Mon May 5 15:27:48 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 25F72106566B; Mon, 5 May 2008 15:27:48 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 04D458FC0C; Mon, 5 May 2008 15:27:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unknown [208.65.91.234]) by elvis.mu.org (Postfix) with ESMTP id 77E9F1A4D84; Mon, 5 May 2008 08:27:47 -0700 (PDT) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m45FRYCF068068; Mon, 5 May 2008 11:27:35 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: src-committers@freebsd.org Date: Mon, 5 May 2008 11:27:44 -0400 User-Agent: KMail/1.9.7 References: <200805021525.m42FP7GC055065@repoman.freebsd.org> In-Reply-To: <200805021525.m42FP7GC055065@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805051127.45177.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 05 May 2008 11:27:35 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7032/Mon May 5 09:38:40 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/stdio Makefile.inc clrerr.c feof.c ferror.c fileno.c getc.c getchar.c local.h putc.c putchar.c unlocked.c xprintf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 May 2008 15:27:48 -0000 On Friday 02 May 2008 11:25:07 am John Baldwin wrote: > jhb 2008-05-02 15:25:07 UTC > > FreeBSD src repository > > Modified files: > include stdio.h > lib/libc/stdio Makefile.inc clrerr.c feof.c ferror.c > fileno.c getc.c getchar.c local.h putc.c > putchar.c xprintf.c > Removed files: > lib/libc/stdio unlocked.c > Log: > Next round of stdio changes: Remove all inlining of stdio operations and > move the definition of the type backing FILE (struct __sFILE) into an > internal header. > - Remove macros to inline certain operations from stdio.h. Applications > will now always call the functions instead. > - Move the various foo_unlocked() functions from unlocked.c into foo.c. > This lets some of the inlining macros (e.g. __sfeof()) move into > foo.c. > - Update a few comments. > - struct __sFILE can now go back to using mbstate_t, pthread_t, and > pthread_mutex_t instead of knowing about their private, backing types. > > MFC after: 1 month > Reviewed by: kan I'll be reverting this shortly. I had misparsed the maze of stdio headers in glibc and thought that it had a fully opaque FILE. I will probably not restore unlocked.c though and just leave foo_unlocked() in foo.c. I will restore all the inlining though since there's not much point in axeing that if we can't make FILE private. -- John Baldwin