From owner-freebsd-arch@FreeBSD.ORG  Thu Jun 12 11:29:02 2003
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7ED3337B401
	for <arch@freebsd.org>; Thu, 12 Jun 2003 11:29:02 -0700 (PDT)
Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A6CE043FBF
	for <arch@freebsd.org>; Thu, 12 Jun 2003 11:29:01 -0700 (PDT)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h5CISrV78377;
	Thu, 12 Jun 2003 14:28:53 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Date: Thu, 12 Jun 2003 14:28:52 -0400 (EDT)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <20030612180335.GA36606@dhcp01.pn.xcllnt.net>
Message-ID: <20030612142802.W36168-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: arch@freebsd.org
cc: Poul-Henning Kamp <phk@phk.freebsd.dk>
Subject: Re: HyperThreading and CPU topologies.
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jun 2003 18:29:02 -0000


On Thu, 12 Jun 2003, Marcel Moolenaar wrote:

> On Thu, Jun 12, 2003 at 01:45:52PM +0200, Poul-Henning Kamp wrote:
> > In message <20030612051553.J36168-100000@mail.chesapeake.net>, Jeff Roberson wr
> > ites:
> > >Index: smp.h
> > >===================================================================
> > >RCS file: /home/ncvs/src/sys/sys/smp.h,v
> > >retrieving revision 1.72
> > >diff -r1.72 smp.h
> > >19a20,46
> > >>
> > >> /*
> > >>  * Topology of a NUMA or HTT system.
> > >>  *
> > >>  * The top level topology is an array of pointers to groups.  Each group
> > >>  * contains a bitmask of cpus in its group or subgroups.  It may also
> > >>  * contain a pointer to an array of child groups.
> > >>  *
> > >>  * The bitmasks at non leaf groups may be used by consumers who support
> > >>  * a smaller depth than the hardware provides.
> > >>  *
> > >>  * The topology may be omitted by systems where all CPUs are equal.
> > >>  */
> > >>
> > >> struct cpu_group {
> > >>       int     cg_mask;                /* Mask of cpus in this group. */
> >
> > u_int ?
> >
> > uint32_t ?
>
> It's best to make it MD depedendent. I prefer 64-bit masks in ia64.
>

I thought I was being consistent with the rest of the file but it turns
out that it uses u_int so I'm changing to that.  If someone wants to make
a pass through the smp code and make a cpu_bitmap_t or something they are
welcome.

Cheers,
Jeff