From owner-cvs-all Sat May 13 13:45:13 2000 Delivered-To: cvs-all@freebsd.org Received: from mass.cdrom.com (adsl-63-202-176-114.dsl.snfc21.pacbell.net [63.202.176.114]) by hub.freebsd.org (Postfix) with ESMTP id 259DC37BFAE; Sat, 13 May 2000 13:44:59 -0700 (PDT) (envelope-from msmith@mass.cdrom.com) Received: from mass.cdrom.com (localhost [127.0.0.1]) by mass.cdrom.com (8.9.3/8.9.3) with ESMTP id NAA05940; Sat, 13 May 2000 13:45:22 -0700 (PDT) (envelope-from msmith@mass.cdrom.com) Message-Id: <200005132045.NAA05940@mass.cdrom.com> X-Mailer: exmh version 2.1.1 10/15/1999 To: Peter Wemm Cc: obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha mem.c In-reply-to: Your message of "Sat, 13 May 2000 13:41:02 PDT." <20000513204102.7508C1CDF@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 13 May 2000 13:45:21 -0700 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > "David O'Brien" wrote: > > On Sat, May 13, 2000 at 12:43:00AM -0700, Peter Wemm wrote: > > > Log: > > > There are still too many diffs relative to the i386 version. > > > > Couldn't the two be merged? (perhaps with just a very few #ifdef's) > > More of it maybe, but take (for instance) the physical addresses. They > are 32bit vs. 64 bit. /dev/mem and /dev/kmem are different too. But we have an MI physical address type (vm_offset_t), so the same code can compile on different pointer-size systems. > IMHO, /dev/null, /dev/zero, /dev/[u]random etc have no business being in > the same driver as /dev/[k]mem. I think *that* is the basic mistake here. > Everything but mem/kmem should be in a MI "misc devices" driver. The only parts of any of this code that I thought should be MD were the interrupt/entropy related parts, and most of those are just plain ugly; I don't think any of them couldn't become MI either. -- \\ Give a man a fish, and you feed him for a day. \\ Mike Smith \\ Tell him he should learn how to fish himself, \\ msmith@freebsd.org \\ and he'll hate you for a lifetime. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message