Date: Thu, 26 Sep 2002 11:24:13 +0930 (CST) From: "Greg 'groggy' Lehey" <grog@lemis.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/43376: audio/lame fails to compile Message-ID: <20020926015413.DAA708147C@wantadilla.lemis.com>
next in thread | raw e-mail | index | archive | help
>Number: 43376
>Category: ports
>Synopsis: audio/lame fails to compile
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Sep 25 19:00:09 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Greg 'groggy' Lehey
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
LEMIS (SA) Pty Ltd
>Environment:
System: FreeBSD current.lemis.com 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Tue Sep 17 01:28:02 GMT 2002 root@:/src/FreeBSD/5-CURRENT-WANTADILLA/src/sys/i386/compile/GENERIC i386
>Description:
source='mp3rtp.c' object='mp3rtp.o' libtool=no depfile='.deps/mp3rtp.Po' tmpdepfile='.deps/mp3rtp.TPo' depmode=gcc3 /bin/sh ../depcomp cc -DHAVE_CONFIG_H -I. -I. -I.. -I../libmp3lame -I../include -I.. -O -pipe -mcpu=pentiumpro -I/usr/X11R6/include/gtk12 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/X11R6/include -c `test -f mp3rtp.c || echo './'`mp3rtp.c
In file included from mp3rtp.c:44:
rtp.h:29:8: macro names must be identifiers
mp3rtp.c:50:1: warning: "MAX_NAME_SIZE" redefined
In file included from mp3rtp.c:39:
main.h:26:1: warning: this is the location of the previous definition
mp3rtp.c: In function `main':
mp3rtp.c:227: warning: passing arg 1 of `maxvalue' from incompatible pointer type
*** Error code 1
Stop in /src/FreeBSD/ports/audio/lame/work/lame-3.91/frontend.
*** Error code 1
>How-To-Repeat:
Try to build the
>Fix:
This fix addresses two issues:
1. The "macro names must be identifiers":
--- frontend/rtp.h.orig Thu Sep 26 11:16:27 2002
+++ frontend/rtp.h Thu Sep 26 09:24:21 2002
@@ -26,7 +26,7 @@
int makesocket(char *szAddr,unsigned short port,unsigned char TTL,struct sockaddr_in *sSockAddr);
void rtp_output(const char *mp3buffer,int mp3size);
-#ifdef 0
+#if 0
int rtp_send (
SOCKET s,
struct rtpheader *foo,
2. The redefinition of MAX_NAME_SIZE. This is just plain
emetic: all sorts of bugs could be hiding here. The
original sources define different values of MAX_NAME_SIZE
for different files, along with arrays of this length.
--- frontend/mp3rtp.c.orig Sat Jun 9 06:59:34 2001
+++ frontend/mp3rtp.c Thu Sep 26 09:27:06 2002
@@ -47,8 +47,6 @@
#include <dmalloc.h>
#endif
-#define MAX_NAME_SIZE 2048 /* current value of Linux */
-
/*
* Encode (via LAME) to mp3 with RTP streaming of the output.
*
--- frontend/main.h.orig Tue Oct 30 08:30:15 2001
+++ frontend/main.h Thu Sep 26 09:27:13 2002
@@ -23,8 +23,7 @@
#include "get_audio.h"
-#define MAX_NAME_SIZE 1000
-
+#define MAX_NAME_SIZE 2048 /* current value of Linux */
/* GLOBAL VARIABLES used by parse.c and main.c.
instantiated in parce.c. ugly, ugly */
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020926015413.DAA708147C>