From owner-freebsd-pf@FreeBSD.ORG  Tue Jan  9 16:03:47 2007
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
X-Original-To: freebsd-pf@freebsd.org
Delivered-To: freebsd-pf@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4285116A503
	for <freebsd-pf@freebsd.org>; Tue,  9 Jan 2007 16:03:47 +0000 (UTC)
	(envelope-from csjp@FreeBSD.ORG)
Received: from ems01.seccuris.com (ems01.seccuris.com [204.112.0.35])
	by mx1.freebsd.org (Postfix) with ESMTP id 101FD13C469
	for <freebsd-pf@freebsd.org>; Tue,  9 Jan 2007 16:03:47 +0000 (UTC)
	(envelope-from csjp@FreeBSD.ORG)
Received: from [127.0.0.1] (stf01.seccuris.com [204.112.0.40])
	by ems01.seccuris.com (Postfix) with ESMTP id E0C8E462E8B;
	Tue,  9 Jan 2007 11:01:48 -0600 (CST)
Message-ID: <45A3BD04.4010905@FreeBSD.ORG>
Date: Tue, 09 Jan 2007 10:04:20 -0600
From: "Christian S.J. Peron" <csjp@FreeBSD.ORG>
User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207)
MIME-Version: 1.0
To: Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw>
References: <200612161335.kBGDZkMj012022@freefall.freebsd.org>
	<200612161709.48875.max@love2party.net>
	<45953727.7020405@FreeBSD.ORG>
	<0701092218228.1404@www.mmlab.cse.yzu.edu.tw>
In-Reply-To: <0701092218228.1404@www.mmlab.cse.yzu.edu.tw>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-pf@freebsd.org
Subject: Re: debug.mpsafenet=1 vs. user/group rules [Re: kern/106805: ...]
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
	\(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jan 2007 16:03:47 -0000

Tai-hwa Liang wrote:
> On Fri, 29 Dec 2006, Christian S.J. Peron wrote:
>> Max,
>>
>> I have replied to this mail and I guess it has been lost, as I have 
>> had no response.  Although this technically makes
>> the problem harmless, all you are doing is moving the lock order 
>> reversal from pf+inpcb to pfil+inpcb. The
>
>   I probably missed something; however, with Max's patch applied, I 
> did not see any pf related LOR on a WITNESS + INVARIANT enabled 
> -STABLE box during
> last two weeks [..]

You won't see it on -STABLE because it doesn't exist. We switched from a 
home rolled reader/writer type lock (with no WITNESS semantics), to a 
standard read/write locking API in -CURRENT.